Commit graph

12172 commits

Author SHA1 Message Date
Joey Hess
1f8996614e
close since bug submittor is happy with new option 2024-01-19 15:31:13 -04:00
Joey Hess
e7c38191e7
Merge branch 'master' of ssh://git-annex.branchable.com 2024-01-19 15:29:59 -04:00
Joey Hess
20567e605a
add directional stalldetection and bwlimit configs
Sponsored-by: Dartmouth College's DANDI project
2024-01-19 15:27:53 -04:00
Joey Hess
c02df79248
use watchFileSize in Remote.External.retrieveKeyFile
external: Monitor file size when getting content from external special
remotes and use that to update the progress meter, in case the external
special remote program does not report progress.

This relies on 703a70cafa to prevent ever
running the meter backwards.

Sponsored-by: Dartmouth College's DANDI project
2024-01-19 14:34:30 -04:00
jstritch
4276cb2015 Added a comment 2024-01-19 17:44:39 +00:00
yarikoptic
3e047f05cf Added a comment 2024-01-18 21:32:30 +00:00
Joey Hess
3ef766c444
comment 2024-01-18 17:16:18 -04:00
Joey Hess
0721fe3463
Merge branch 'master' of ssh://git-annex.branchable.com 2024-01-18 17:13:05 -04:00
Joey Hess
c2634e7df2
automatically adjust stall detection period
Improve annex.stalldetection to handle remotes that update progress less
frequently than the configured time period.

In particular, this makes remotes that don't report progress but are
chunked work when transferring a single chunk takes longer than the
specified time period.

Any remotes that just have very low update granulatity would also be
handled by this.

The change to Remote.Helper.Chunked avoids an extra progress update when
resuming an interrupted upload. In that case, the code saw first Nothing
and then Just the already transferred number of bytes, which defeated this
new heuristic. This change will mean that, when resuming an interrupted
upload to a chunked remote that does not do its own progress reporting, the
progress display does not start out displaying the amount sent so far,
until after the first chunk is sent. This behavior change does not seem
like a major problem.

About the scalefudgefactor, it seems reasonable to expect subsequent chunks
to take no more than 1.5 times as long as the first chunk to transfer.
Could set it to 1, but then any chunk taking a little longer would be
treated as a stall. 2 also seems a likely value. Even 10 might be fine?

Sponsored-by: Dartmouth College's DANDI project
2024-01-18 17:12:10 -04:00
yarikoptic
4fe3e59525 Added a comment 2024-01-18 19:00:51 +00:00
Joey Hess
931920c426
comment 2024-01-18 13:14:17 -04:00
Joey Hess
ae4177ec4e
comment 2024-01-18 13:01:04 -04:00
Joey Hess
adb8b320e3
cleanup 2024-01-18 12:42:26 -04:00
Joey Hess
e765d3e24c
import: --message/-m option 2024-01-18 12:41:44 -04:00
Joey Hess
05026e2053
not a bug 2024-01-18 12:11:10 -04:00
Joey Hess
ccc64bc8ff
fixed 2024-01-18 11:56:03 -04:00
Joey Hess
517904b770
Merge branch 'master' of ssh://git-annex.branchable.com 2024-01-18 11:53:20 -04:00
imlew
38e79ba1d7 2024-01-17 14:32:12 +00:00
jkniiv
92bb192c3a Added a comment 2024-01-16 23:23:27 +00:00
jkniiv
b9339d9f5d Added a comment: I can confirm 2024-01-16 22:28:22 +00:00
Joey Hess
285073712a
close 2024-01-16 14:38:49 -04:00
yarikoptic
8fd6c3f1b1 windows build is broken 2024-01-15 15:38:43 +00:00
aurelien@f0d0a0c7da69eff6badf0464898f0a859f69114d
34cf5be43d Added a comment 2024-01-14 23:18:43 +00:00
jstritch
acca5ab06b 2024-01-14 16:23:13 +00:00
jstritch
629f570288 2024-01-14 16:15:36 +00:00
jstritch
181e14467f 2024-01-11 18:24:52 +00:00
Joey Hess
cd28366855
reverted problem commit 2024-01-10 16:37:29 -04:00
yarikoptic
61384f155e 2024-01-06 18:31:18 +00:00
yarikoptic
46ab66d97a reporting about --listen 2024-01-06 16:00:05 +00:00
yarikoptic
077a99bebb new issue about stalling transfers 2024-01-04 20:23:34 +00:00
kdm9
d5e1dd195e Added a comment: confirmed fixed 2024-01-03 09:03:44 +00:00
Joey Hess
bcbad66cf3
comment 2024-01-02 14:08:01 -04:00
lemondata
2957eed1f0 Added a comment 2024-01-02 15:44:21 +00:00
Lukey
1a3124c000 Added a comment 2023-12-30 11:35:22 +00:00
Lukey
6419936626 2023-12-30 10:51:29 +00:00
Lukey
b4dd62235a 2023-12-30 10:49:32 +00:00
Joey Hess
8a3beabf35
use RawFilePath for opening sqlite databases
Fix a crash opening sqlite databases when run in a non-unicode locale,
with a remote that uses a non-unicode filepath. In that situation
converting to Text fails.

The fix needs git-annex to be built with persistent-sqlite 2.13.3.
Building against older versions still works, but that version is used when
building with stack.

Database.RawFilePath is a lot of code copied from persistent-sqlite and
lightly modified, since only 1 function in persistent-sqlite was made to
support RawFilePath. This is a bit of a pain, and I hope that
persistent-sqlite will eventually switch to using OsPath, allowing this
module to be removed from git-annex.

Sponsored-by: k0ld on Patreon
2023-12-26 18:31:52 -04:00
Atemu
2fe31d81d3 Added a comment 2023-12-25 13:03:50 +00:00
Joey Hess
3b888369d3
comment 2023-12-20 15:56:36 -04:00
Joey Hess
d7ca716759
response 2023-12-20 13:12:56 -04:00
jkniiv
6c0259018a close bug as notabug due to user error 2023-12-19 23:12:21 +00:00
jkniiv
191dde2857 Added a comment: my report was actually a User Failure on my part 2023-12-19 23:02:16 +00:00
lemondata
19edfc69a7 2023-12-19 00:17:00 +00:00
jkniiv
9189c41dde report on the 'Production' build flag not producing a binary that passes the test suite 2023-12-08 16:38:12 +00:00
nobodyinperson
df62843f64 Added a comment: Similar to initremote type=git 2023-12-07 08:31:09 +00:00
Joey Hess
1f811c340d
kinda a bug 2023-12-05 16:43:14 -04:00
Joey Hess
a6eb7d7339
prevent relatedTemplate from truncating a filename to end in "."
Avoid a problem with temp file names ending in "." on certian filesystems
that have problems with such filenames.

relatedTemplate is quite an ugly hack really; since it doesn't know the max
filename length of the filesystem it can only assume that the filename is
max allowed length. When given the input "lh.aparc.DKTatlas.annot", it
wants to reserve 20 characters for tempfile so it truncates to "lh.". That
ending period is apparently a problem on some filesystem (FAT eats it, but
does not throw EINVAL; ntfs does not seem bothered by it, I don't know what
FUSE filesystem the bug reporter was really using).

Sponsored-by: Brett Eisenberg on Patreon
2023-12-05 12:38:14 -04:00
cjmarkie
545f3873ca No change. Just subscribing to comments. 2023-12-05 16:04:46 +00:00
cjmarkie
f6f4ba3c6c 2023-12-05 14:54:11 +00:00
nobodyinperson
9906e8fd4c Added a comment: How about a --offline flag? 2023-12-04 17:52:44 +00:00