Commit graph

37909 commits

Author SHA1 Message Date
Joey Hess
506ffea5e6
stop symlink check once the top of the working tree is reached
Avoid complaining that a file with "is beyond a symbolic link" when the
filepath is absolute and the symlink in question is not actually inside the
git repository.

This assumes that inodes remain stable while the command is running.
I think they always will, the filesystems where they are unstable change
them across mounts. (If inodes were not stable, it would just complain about
symlinks in the path that are not inside the working tree.)

(On windows, I don't want to assume anything about inodes, they could be
random numbers for all I know. But if they were, this would still be ok, as
long as windows doesn't have symlinks that are detected by isSymbolicLink.
Which seems a fair bet.)
2020-08-06 20:14:30 -04:00
kyle
683f527b3b Added a comment 2020-08-06 20:58:21 +00:00
Joey Hess
a358eb1faa
comment 2020-08-06 14:38:06 -04:00
Joey Hess
4288f7576a
comment 2020-08-06 13:59:22 -04:00
Joey Hess
62214244d3
Merge branch 'master' of ssh://git-annex.branchable.com 2020-08-06 13:52:19 -04:00
Joey Hess
5d380c6c5c
when workTreeItems finds a problem with a parameter, don't go on to process it
Part of workTreeItems is trying detect a case
where git porcelain refuses to process a file, and where
git ls-files silently outputs nothing. But, it's hard to perfectly
replicate git's behavior, and besides, git's behavior could change.
So it could be that we warn, but then git ls-files does not skip over
it, and so git-annex also processes it after warning about it.

So, if we think we have a problem with a parameter, display the warning,
and skip processing it at all.

Implementing this was complicated by needing to handle the case where
all command-line parameters get filtered out this way. Which is
different than the case where there are none, because we don't want to
operate on all files in this new case..
2020-08-06 13:47:45 -04:00
Joey Hess
8312cac018
comment and moreinfo 2020-08-06 11:30:44 -04:00
Joey Hess
e2a662892e
forgot to close this earlier 2020-08-06 11:22:42 -04:00
cardoso-neto
ec0fdbb95d Added a comment: Fixing URLs. 2020-08-06 03:15:00 +00:00
cardoso-neto
ffe3a26d83 Added a comment: Correction. 2020-08-06 03:09:16 +00:00
cardoso-neto
860b1f9f17 Create bug report thread on ungraceful exit after cwd being moved/baleeted 2020-08-06 02:55:32 +00:00
cardoso-neto
38d442889c Added a comment: Improperly documented code. 2020-08-06 02:52:51 +00:00
Joey Hess
9948b8b3de
update 2020-08-05 17:47:55 -04:00
Joey Hess
8bfa7990b5
make symlinks not hardlinks
hardlinks happened to work because it was a hard link to a symlink, but
it would have failed if eg git-annex-shell symlink did not exist,
perhaps because the Makefile was not run to build it. Or something like
that. Also, it seems like it worked by accident and the Makefile used to
ln -s.
2020-08-05 11:58:22 -04:00
Joey Hess
ce93cc43c4
update 2020-08-05 11:49:21 -04:00
Joey Hess
ec4e742066
create missing directory 2020-08-05 11:37:03 -04:00
Joey Hess
283d2f85d1
importfeed: Fix reversion that caused some '.' in filenames to be replaced with '_'
sanitizeFilePath was changed to sanitize leading '.', but ImportFeed was
running it on parts of the template. So eg the leading '.' in the extension
got sanitized.

Note the added case for sanitizeLeadingFilePathCharacter ('/':_)
-- this was added because, if the template is title/episode and the title
is not set, it would expand to "/episode". So this is another potential
security fix.
2020-08-05 11:35:00 -04:00
Joey Hess
b4db85c265
Merge branch 'master' of ssh://git-annex.branchable.com 2020-08-05 10:39:55 -04:00
Joey Hess
9994c5882c
further change to support dlist-1.0
Its tail no longer yields a DList.
2020-08-05 10:37:14 -04:00
madalu
d8517d6cfc Reporting importfeed filename bug 2020-08-04 17:19:06 +00:00
Lukey
7077a7c2e7 Added a comment 2020-08-04 14:10:33 +00:00
Joey Hess
bdfe6f7420
fix build in clean tree
removeDirectoryRecursive fails if the directory DNE.
2020-08-03 19:43:21 -04:00
Joey Hess
88e5ebcda7
runshell LD_HWCAP_MASK=0 optimisation 2020-08-03 14:34:15 -04:00
Joey Hess
e62817c00d
move standalone building code out of Makefile and into Build.Standalone
This includes making Build.Standalone run LinuxMkLibs or OSXMkLibs
rather than doing that separately. Which is groundwork for a later
optimisation.

Also it simplified the code some.
2020-08-03 14:15:03 -04:00
git-annex.branchable.com@79d6855760f61f7fbe0a401b45d8c791ef49b500
465842f3f6 Added a comment 2020-08-02 23:41:33 +00:00
yarikoptic
5a5e13e972 Added a comment 2020-08-02 01:31:53 +00:00
yarikoptic
7bd1e392dc Added a comment 2020-07-31 21:48:21 +00:00
yarikoptic
592db0629e Added a comment 2020-07-31 21:37:48 +00:00
kyle
960180dece Added a comment 2020-07-31 21:30:34 +00:00
yarikoptic
2b9d8b4e08 Added a comment 2020-07-31 21:23:57 +00:00
kyle
d844d0a1b7 Added a comment 2020-07-31 21:20:10 +00:00
Joey Hess
f5724d78d4
comment 2020-07-31 16:47:23 -04:00
Joey Hess
5a5873e052
fix bug caught by test suite 2020-07-31 16:11:50 -04:00
Joey Hess
13db029ac0
comment 2020-07-31 16:11:10 -04:00
Joey Hess
8b4e5e6f68
Merge branch 'master' of ssh://git-annex.branchable.com 2020-07-31 14:58:02 -04:00
Joey Hess
c4ec52b9ae
Slightly sped up the linux standalone bundle
Reduce the number of directories listed in libdirs, which makes the linker
check a lot less dead ends looking for directories.

Eliminated some directories that didn't really contain shared libraries,
or only contained the linker.

That left only 2, one in lib and one in usr/lib, so consolidate those two.

Doing it this way, rather than just consolidating all libs that might exist
into a single directory means that, if there are optimised versions of some
libs, eg in lib/subarch/foo.so, and lib/subarch2/foo.so, they don't get
moved around in a way that would make the linker pick the wrong one.
2020-07-31 14:42:03 -04:00
Joey Hess
676257dfa8
comment 2020-07-31 13:29:48 -04:00
kyle
7bae35d840 prop_isomorphic_key_encode test failure 2020-07-30 17:51:20 +00:00
Ilya_Shlyakhter
85e57d8260 Added a comment: streaming data and external backends 2020-07-30 15:58:24 +00:00
Ilya_Shlyakhter
6a91ddddbc Added a comment: thanks 2020-07-30 15:51:16 +00:00
Ilya_Shlyakhter
23d15dc985 Added a comment: key length 2020-07-30 15:13:53 +00:00
Joey Hess
8200b52e12
Merge branch 'master' of ssh://git-annex.branchable.com 2020-07-29 17:28:34 -04:00
Joey Hess
877d9c4283
devblog 2020-07-29 17:27:51 -04:00
Joey Hess
049807dbba
external backends implemented 2020-07-29 17:24:34 -04:00
Joey Hess
ea63d1dfe3
E variant of external backend keys 2020-07-29 17:12:22 -04:00
Joey Hess
b6fa4cb42f
external backends genKey and verifyKeyContent implemented
Only key translation for HasExt remains..
2020-07-29 16:36:32 -04:00
Joey Hess
f75be32166
external backends wip
It's able to start them up, the only thing not implemented is generating
and verifying keys. And, the key translation for HasExt.
2020-07-29 15:23:18 -04:00
Joey Hess
b5d6a36db0
note external backend names cannot end with E
also markdown improvements
2020-07-29 14:01:49 -04:00
Joey Hess
555fe669e1
refactoring in preparation for external backends 2020-07-29 12:00:27 -04:00
Ilya_Shlyakhter
8bc12d3cc4 Added a comment: version correspondence of standalone builds and official releases 2020-07-29 15:36:39 +00:00