Commit graph

40874 commits

Author SHA1 Message Date
Joey Hess
eb95ed4863
fix addurl concurrency issue
addurl: Support adding the same url to multiple files at the same time when
using -J with --batch --with-files.

Implementation was easier than expected, was able to reuse OnlyActionOn.

While it will download the url's content multiple times, that seems like
the best thing to do; see my comment for why.

Sponsored-by: Dartmouth College's DANDI project
2021-10-27 16:15:41 -04:00
Joey Hess
a3cdff3fd5
add a comment about checkSaneLock
See commit 8c2dd7d8ee for original
introduction of it, but needing to spelunk that far back to understand
the code is not good.
2021-10-27 14:55:30 -04:00
Joey Hess
55bfa414b3
move transfer already in progress message to warning
This makes it be displayed in the error-messages field with
--json-error-messages. And with --quiet, it will let it be displayed,
which makes sense because it's telling the user why what they requested
to do has failed to happen.
2021-10-27 14:46:21 -04:00
Joey Hess
1d0c07a3af
Merge branch 'master' of ssh://git-annex.branchable.com 2021-10-27 14:40:41 -04:00
Joey Hess
c1229f959a
comment 2021-10-27 14:40:02 -04:00
jwodder
93cbdf18fe Added a comment 2021-10-27 18:19:23 +00:00
Joey Hess
4efa4fdd12
comment 2021-10-27 14:18:19 -04:00
Joey Hess
669037862a
avoid redundant freezeContent call
This opens the potential for the object file to be in place but
git-annex is interrupted before it can freeze it. git-annex fsck already
fixes that situation, which can also occur when lockContentForRemoval
thaws content.

Also improve comment to not be Windows-specific.
2021-10-27 14:18:10 -04:00
jwodder
2a70a051b0 Added a comment 2021-10-27 18:16:44 +00:00
Reiko Asakura
0db7297f00
Call freezeContent after move into annex
This change better supports Windows ACL management using
annex.freezecontent-command and annex.thawcontent-command and matches
the behaviour of adding an unlocked file.

By calling freezeContent after the file has moved into the annex,
the file's delete permission can be denied. If the file's delete
permission is denied before moving into the annex, the file cannot
be moved or deleted. If the file's delete permission is not denied after
moving into the annex, it will likely inherit a grant for the delete
permission which allows it to be deleted irrespective of the permissions
of the parent directory.
2021-10-27 14:05:57 -04:00
Joey Hess
82e3eb5af3
comment 2021-10-27 13:55:36 -04:00
Joey Hess
8f3bbaf30f
comment 2021-10-27 12:56:09 -04:00
Joey Hess
0756625e1b
update, bugfix also fixed git-annex info 2021-10-27 12:22:02 -04:00
Joey Hess
43c598d41a
comment 2021-10-27 12:21:43 -04:00
jwodder
24d6906d3e 2021-10-27 16:08:30 +00:00
mich_hein@7649a6a913fc77618845b4f94a5ae54fa432708a
f78761929c 2021-10-27 13:28:56 +00:00
jkniiv
77803642bb Added a comment 2021-10-26 23:55:13 +00:00
asakurareiko@f3d908c71c009580228b264f63f21c7274df7476
c4c01719b9 2021-10-26 22:37:52 +00:00
asakurareiko@f3d908c71c009580228b264f63f21c7274df7476
a50bd7b2b9 Added a comment 2021-10-26 20:13:19 +00:00
asakurareiko@f3d908c71c009580228b264f63f21c7274df7476
10582d1fe3 Updated patch 2021-10-26 19:55:58 +00:00
asakurareiko@f3d908c71c009580228b264f63f21c7274df7476
d607446043 Added a comment 2021-10-26 19:54:53 +00:00
Joey Hess
b2c48fb86b
Fix using lookupkey inside a subdirectory
Caused by dirContains ".." "foo" being incorrectly False.

Also added a test of dirContains, which includes all the previous bug fixes
I could find and some obvious cases.

Reversion in version 8.20211011

Sponsored-by: Brett Eisenberg on Patreon
2021-10-26 15:00:45 -04:00
Joey Hess
91eb393df4
comment 2021-10-26 14:25:28 -04:00
Joey Hess
3aaf6ade30
review 2021-10-26 14:08:56 -04:00
Joey Hess
5a9e6b1fd4
when private journal file exists, still read from git-annex branch
Fix bug that caused stale git-annex branch information to read when
annex.private or remote.name.annex-private is set.

The private journal file should not prevent reading more current
information from the git-annex branch, but used to.

Note that, overBranchFileContents has to do additional work now, when
there's a private journal file, it reads from the branch redundantly
and more slowly.

Sponsored-by: Jack Hill on Patreon
2021-10-26 13:43:50 -04:00
Joey Hess
c5bf4d3504
Merge branch 'master' of ssh://git-annex.branchable.com 2021-10-26 12:11:40 -04:00
Lukey
0a04986ac8 Added a comment 2021-10-25 10:25:05 +00:00
Lukey
9f1bf48696 2021-10-25 10:16:35 +00:00
pat
cc877dfe45 Added a comment 2021-10-24 22:42:35 +00:00
asakurareiko@f3d908c71c009580228b264f63f21c7274df7476
b2c797e35b Added a comment 2021-10-24 21:23:56 +00:00
jwodder
be3cf1115e 2021-10-24 19:21:54 +00:00
asakurareiko@f3d908c71c009580228b264f63f21c7274df7476
63313e0b40 2021-10-24 19:12:23 +00:00
jkniiv
4471aae22f still think we should highlight this as new info 2021-10-24 15:10:13 +00:00
username
6f3cadcbda Added a comment 2021-10-23 15:53:57 +00:00
asakurareiko@f3d908c71c009580228b264f63f21c7274df7476
42eaa6f8c9 Moved WSL1 guide to a tips page 2021-10-22 22:14:40 +00:00
asakurareiko@f3d908c71c009580228b264f63f21c7274df7476
ebe022e9cf 2021-10-22 22:13:46 +00:00
asakurareiko@f3d908c71c009580228b264f63f21c7274df7476
29dfc0a9bf Added a comment 2021-10-22 15:58:11 +00:00
asakurareiko@f3d908c71c009580228b264f63f21c7274df7476
201ac941a7 2021-10-21 21:24:24 +00:00
asakurareiko@f3d908c71c009580228b264f63f21c7274df7476
f9e09277c5 2021-10-21 17:17:42 +00:00
git-annex.visiteur@e9d364191d2ffc1b163c8d9e4c57dbadf58aad8e
efaa1fe94a Added a comment 2021-10-21 08:24:55 +00:00
Joey Hess
2b6e287013
remove obsolete libgcc1
last seen in debian oldstable
2021-10-21 03:02:16 -04:00
jwodder
471464e4a0 2021-10-21 04:54:26 +00:00
asakurareiko@f3d908c71c009580228b264f63f21c7274df7476
f8faeabb70 Added a comment 2021-10-21 02:09:02 +00:00
asakurareiko@f3d908c71c009580228b264f63f21c7274df7476
ae80b1214c Added a comment 2021-10-21 02:06:50 +00:00
jwodder
c6d1c7d209 2021-10-21 01:35:48 +00:00
asakurareiko@f3d908c71c009580228b264f63f21c7274df7476
67baa63e5b Added a comment 2021-10-20 22:54:39 +00:00
Joey Hess
6bed8ccbd1
comment 2021-10-20 15:25:35 -04:00
Joey Hess
ca7d44b0c2
Merge branch 'master' of ssh://git-annex.branchable.com 2021-10-20 15:16:42 -04:00
Joey Hess
d3bea30a6b
fix build failure on windows
Utility.QuickCheck also has an instance Arbitrary FileID.
It seems that this problem used to be ignored by ghc but now it notices
it.
2021-10-20 15:12:12 -04:00
git-annex.visiteur@e9d364191d2ffc1b163c8d9e4c57dbadf58aad8e
16b08ffcd9 Added a comment: Same problem with git-annex 8.20210223 2021-10-20 19:09:29 +00:00