From fb318c034ce201c022c6f0c80a3aff61fe12f250 Mon Sep 17 00:00:00 2001 From: Joey Hess Date: Wed, 18 Sep 2019 13:47:01 -0400 Subject: [PATCH] appears already fixed --- ...tries_to_lock_in_home_directory__63__.mdwn | 2 +- ..._3f985fc652c9a15b5989cc82cb5da1ad._comment | 29 +++++++++++++++++++ 2 files changed, 30 insertions(+), 1 deletion(-) create mode 100644 doc/bugs/get_-J_from_ssh_remote_tries_to_lock_in_home_directory__63__/comment_2_3f985fc652c9a15b5989cc82cb5da1ad._comment diff --git a/doc/bugs/get_-J_from_ssh_remote_tries_to_lock_in_home_directory__63__.mdwn b/doc/bugs/get_-J_from_ssh_remote_tries_to_lock_in_home_directory__63__.mdwn index 77b2b1ccf3..8c7197c1d2 100644 --- a/doc/bugs/get_-J_from_ssh_remote_tries_to_lock_in_home_directory__63__.mdwn +++ b/doc/bugs/get_-J_from_ssh_remote_tries_to_lock_in_home_directory__63__.mdwn @@ -46,4 +46,4 @@ Most of the days of the week. Friday is a tricky one [[!meta author=yoh]] - +> [[done]]; see my comment --[[Joey]] diff --git a/doc/bugs/get_-J_from_ssh_remote_tries_to_lock_in_home_directory__63__/comment_2_3f985fc652c9a15b5989cc82cb5da1ad._comment b/doc/bugs/get_-J_from_ssh_remote_tries_to_lock_in_home_directory__63__/comment_2_3f985fc652c9a15b5989cc82cb5da1ad._comment new file mode 100644 index 0000000000..7aedcb64da --- /dev/null +++ b/doc/bugs/get_-J_from_ssh_remote_tries_to_lock_in_home_directory__63__/comment_2_3f985fc652c9a15b5989cc82cb5da1ad._comment @@ -0,0 +1,29 @@ +[[!comment format=mdwn + username="joey" + subject="""comment 2""" + date="2019-09-18T17:26:37Z" + content=""" +So, this bug is mistitled, it's not about locking, but about looking. + +Or more clearly, something about file paths that end up pointing to a home directory. + + fatal: Not a git repository: '../../../home/bids/.git' git-annex-shell: Not a git-annex or gcrypt repository. + + Unable to run git-annex-shell on remote . + +The second message used to be output by the code path warming up the ssh +connection to handle concurrency. That code path has since changed, and no +longer tries to run git-annex-shell there. + +And, notice the "remote ." -- that means that +`Git.repoDescribe (gitConfigRepo (remoteGitConfig gc))` produced "." + +And the git-annex shell command was similarly passed a directory +of `Git.repoPath $ gitConfigRepo $ remoteGitConfig gc` + +So, it was running "git-annex-shell ." which got converted to an absolute path by git-annex-shell +when CWD was $HOME, and then re-relevatized. + +Clearly that code was pretty broken, apparently more than I knew at the time +I fixed it. I do think it's fixed though, by [[!commit 3dd43df9c2748df355314cd07b2bb8ebd30be69e]]. +"""]]