Merge branch 'master' of ssh://git-annex.branchable.com

This commit is contained in:
Joey Hess 2013-12-09 17:43:09 -04:00
commit f8e1d2fd09
4 changed files with 58 additions and 0 deletions

View file

@ -0,0 +1,20 @@
### Please describe the problem.
I noticed that you (@joey) wrote
> webapp: Odd problem when using Firefox: Some links don't seem to load. Clicking on such a link repeatedly will eventually load the right page. Network console shows web browser is requesting page "/" despite a link to another page being clicked on. Workaround: Use Chrome instead; no such problem there.
in [[todo/windows_support]], and thought I would get around to mentioning that I also see this problem on linux (so it's not windows specific), but I am using firefox.
### What steps will reproduce the problem?
Click on a link in the webapp; most of the time, even though the link target is correct, the current page is reloaded instead of loading the target.
### What version of git-annex are you using? On what operating system?
5.20131205-gc448602
Ubuntu 13.04, firefox 25.0.1
--Walter

View file

@ -0,0 +1,18 @@
[[!comment format=mdwn
username="http://joeyh.name/"
ip="209.250.56.64"
subject="comment 1"
date="2013-12-09T21:08:29Z"
content="""
Thanks, that's very interesting indeed.
When I was debugging this on Windows, I had the network console open, and could see clearly that Firefox was trying to load \"/\" when I clicked on a link to \"/config\". Both firefox and the git-annex webapp's debug log agreed that it asked for the wrong page.
I have just reproduced it using iceweasel as well. I know that I have tested git-annex before under iceweasel and it seemed to work.
Seems that clicking 3+ times on a link makes it finally follow it.
I wonder if this has something to do with the long polling. Disabling javascript would avoid it if so. They've made disabling JS in firefox sufficiently hard that I cannot find how to do it.
Also, the problem seems to open happen on the main page (/). Once I get to any other page, further links are followed without trouble.
"""]]

View file

@ -0,0 +1,12 @@
[[!comment format=mdwn
username="http://joeyh.name/"
ip="209.250.56.64"
subject="comment 2"
date="2013-12-09T21:39:16Z"
content="""
Tried renaming / to /dashboard , just in case firefox was having problems with the name of the page. Didn't help, so the problem must be something on the page.
Tried removing the repolist and the transferlist from the dashboard, and this indeed avoided the problem. So it's certainly related to the long polling code. Although note that this left 1 long polling call still on the page, for the sidebar. In fact, only removing one of the repolist or transfer list seems to be enough to avoid the problem. 1 works, 2 works, 3 fails.
Aha.. After 3 long polling failures, the JS runs a fail function. To work around a seeming bug in chromium when navigating back to a page, [[!commit b5678d74a29023cbeb3d65c0d7f57d20f47ebef9]] made this reload the page.
"""]]

View file

@ -0,0 +1,8 @@
[[!comment format=mdwn
username="https://launchpad.net/~maestro-alubia"
nickname="maestro-alubia"
subject="comment 1"
date="2013-12-09T19:47:32Z"
content="""
Yeah! Looking forward to finally introduce git-annex in my heterogeneous network. Thanks and keep up the good work!
"""]]