When auto-upgrading a v3 remote, avoid upgrading to version 6, instead keep it at version 5.

Fixes a bug introduced with v6 mode that I didn't notice until now.
Probably not many v3 repos left out there, and upgrading them to v6 mode
is not disastrous, only a little premature.

This commit was sponsored by Riku Voipio

Annex/Init.hs

@@ -93,7 +93,8 @@ initialize' mversion = do
 		Database.Keys.scanAssociatedFiles
 	v <- checkAdjustedClone
 	case v of
-		NeedUpgradeForAdjustedClone -> void $ upgrade True
+		NeedUpgradeForAdjustedClone -> 
+			void $ upgrade True  versionForAdjustedClone
 		InAdjustedClone -> return ()
 		NotInAdjustedClone ->
 			ifM (crippledFileSystem <&&> (not <$> isBareRepo))

Annex/Version.hs

@@ -24,6 +24,9 @@ latestVersion = "6"
 supportedVersions :: [Version]
 supportedVersions = ["5", "6"]
 
+versionForAdjustedClone :: Version
+versionForAdjustedClone = "6"
+
 upgradableVersions :: [Version]
 #ifndef mingw32_HOST_OS
 upgradableVersions = ["0", "1", "2", "3", "4", "5"]

CHANGELOG

@@ -23,6 +23,8 @@ git-annex (6.20160924) UNRELEASED; urgency=medium
     were not limited to:
     - git commit -a of a large unlocked file (in v5 mode)
     - git-annex adjust when a large file was checked into git directly
+  * When auto-upgrading a v3 remote, avoid upgrading to version 6,
+    instead keep it at version 5.
 
  -- Joey Hess <id@joeyh.name>  Mon, 26 Sep 2016 16:46:19 -0400
 

Command/Upgrade.hs

@@ -26,5 +26,5 @@ start = do
 	showStart "upgrade" "."
 	whenM (isNothing <$> getVersion) $ do
 		initialize Nothing Nothing
-	r <- upgrade False
+	r <- upgrade False latestVersion
 	next $ next $ return r

Upgrade.hs

@@ -26,7 +26,7 @@ checkUpgrade = maybe noop error <=< needsUpgrade
 needsUpgrade :: Version -> Annex (Maybe String)
 needsUpgrade v
 	| v `elem` supportedVersions = ok
-	| v `elem` autoUpgradeableVersions = ifM (upgrade True)
+	| v `elem` autoUpgradeableVersions = ifM (upgrade True defaultVersion)
 		( ok
 		, err "Automatic upgrade failed!"
 		)
@@ -37,13 +37,14 @@ needsUpgrade v
 		" is not supported. " ++ msg
 	ok = return Nothing
 
-upgrade :: Bool -> Annex Bool
+upgrade :: Bool -> Version -> Annex Bool
-upgrade automatic = do
+upgrade automatic destversion = do
 	upgraded <- go =<< getVersion
 	when upgraded $
-		setVersion latestVersion
+		setVersion destversion
 	return upgraded
   where
+	go (Just v) | v >= destversion = return True
 #ifndef mingw32_HOST_OS
 	go (Just "0") = Upgrade.V0.upgrade
 	go (Just "1") = Upgrade.V1.upgrade

Upgrade/V1.hs

@@ -19,7 +19,6 @@ import qualified Annex.Queue
 import qualified Git
 import qualified Git.LsFiles as LsFiles
 import Backend
-import Annex.Version
 import Utility.FileMode
 import Utility.Tmp
 import qualified Upgrade.V2
@@ -52,16 +51,13 @@ upgrade = do
 	showAction "v1 to v2"
 	
 	ifM (fromRepo Git.repoIsLocalBare)
-		( do
+		( moveContent
-			moveContent
-			setVersion latestVersion
 		, do
 			moveContent
 			updateSymlinks
 			moveLocationLogs
 	
 			Annex.Queue.flush
-			setVersion latestVersion
 		)
 	
 	Upgrade.V2.upgrade