mirrors/git-annex
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 2

promote comment to bug

Browse source
This commit is contained in:
Joey Hess 2023-03-27 14:10:32 -04:00
parent c1d0f90081
commit f4a390b2a6
No known key found for this signature in database
GPG key ID: DB12DB0FF05F8F38
3 changed files with 40 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
doc/bugs/securehashesonly_conflicts_with_addurl.mdwn Normal file
View file

@ -0,0 +1,15 @@
Turning on `securehashesonly` seems to disable the `addurl` command:
```console
% git config --get annex.securehashesonly
true
% git annex addurl https://www.gutenberg.org/cache/epub/2591/pg2591-images.html
addurl https://www.gutenberg.org/cache/epub/2591/pg2591-images.html
annex.securehashesonly blocked transfer of URL key
failed
addurl: 1 failed
% git annex addurl https://www.gutenberg.org/cache/epub/2591/pg2591-images.html --relaxed
addurl https://www.gutenberg.org/cache/epub/2591/pg2591-images.html (to www.gutenberg.org_cache_epub_2591_pg2591-images.html) ok
(recording state in git...)
% ls -l www.gutenberg.org_cache_epub_2591_pg2591-images.html
www.gutenberg.org_cache_epub_2591_pg2591-images.html -> .git/annex/objects/gg/kG/URL--https&c%%www.gutenberg.org%cache%epub%2591%pg2591-images.html/URL--https&c%%www.gutenberg.org%cache%epub%2591%pg2591-images.html

18
doc/bugs/securehashesonly_conflicts_with_addurl/comment_1_808e276381f98b4ebb7d61628db703d9._comment Normal file
View file

@ -0,0 +1,18 @@
[[!comment format=mdwn
username="joey"
subject="""comment 1"""
date="2023-03-27T18:03:11Z"
content="""
I think that git-annex addurl without --fast or --relaxed should
work with annex.securehashesonly set. (Unless annex.backend is set
to something it prevents adding.) It is currently failing because
of a temporary URL key that never reaches the repository. So the check
should be disabled for that.
Arguably with --relaxed (or --fast) it should also fail. However,
that does not actually download the content, so it does not technically
add content to the repository that is not using a cryptographically
signed hash. That's how it manages to skate by without failing.
Of course git-annex get will later fail, git-annex fsck
will complain, etc.
"""]]

7
doc/git-annex-addurl/comment_16_c6e1743647bb4d45b5a1b237f53d77a6._comment Normal file
View file

@ -0,0 +1,7 @@
[[!comment format=mdwn
username="joey"
subject="""Re: securehashesonly conflicts with addurl"""
date="2023-03-27T17:59:35Z"
content="""
Opened a bug report: [[bugs/securehashesonly_conflicts_with_addurl]]
"""]]