force strict host key checking when host is known

Avoid any possibilty of prompting in ssh setup in webapp.

Prticularly on Windows this was a problem, it seemed to enter an infinite
loop. I think that ssh can sometimes use SSH_ASKPASS for y/n prompting,
when no controlling TTY is available, and since git-annex always answers
back with the host's password, not y/n, it looped.

This commit was sponsored by Simon Michael.

Assistant/WebApp/Configurators/Ssh.hs

@@ -266,17 +266,18 @@ testServer sshinput@(SshInput { inputHostname = Just hn }) = do
 			, getgitconfig (T.unpack <$> inputDirectory sshinput)
 			]
 		knownhost <- liftIO $ knownHost hn
-		let sshopts = catMaybes
+		let sshopts =
 			{- If this is an already known host, let
 			 - ssh check it as usual.
 			 - Otherwise, trust the host key. -}
-			[ if knownhost then Nothing else Just (sshOpt "StrictHostKeyChecking" "no")
+			[ sshOpt "StrictHostKeyChecking" $
-			, Just "-n" -- don't read from stdin
+				if knownhost then "yes" else "no"
-			, Just "-p", Just (show (inputPort sshinput))
+			, "-n" -- don't read from stdin
-			, Just $ genSshHost
+			, "-p", show (inputPort sshinput)
+			, genSshHost
 				(fromJust $ inputHostname sshinput)
 				(inputUsername sshinput)
-			, Just remotecommand
+			, remotecommand
 			]
 		parsetranscript . fst <$> sshAuthTranscript sshinput sshopts Nothing
 	parsetranscript s =