mirrors/git-annex
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

comment

Browse source
This commit is contained in:
Joey Hess 2020-02-20 14:45:12 -04:00
parent 3d00a8a1dc
commit f2a925a3f5
No known key found for this signature in database
GPG key ID: DB12DB0FF05F8F38
1 changed files with 22 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

22
doc/todo/more_extensive_retries_to_mask_transient_failures/comment_9_4fe7beb47e88259a72a1cd42c85761a5._comment Normal file
View file

@ -0,0 +1,22 @@
[[!comment format=mdwn
username="joey"
subject="""comment 9"""
date="2020-02-20T18:31:59Z"
content="""
Hmm, the reason I'm not worried about leaking open FDs
when killing threads is because `bracket` is generally used
when opening files, with a cleanup action that closes them.
(when not doing lazy IO and letting the GC close the file once the value
goes out of scope). So when a thread is canceled, the cleanup actions
automatically run.
So what's needed is a way to use `bracket` for the non-interactive,
non-pooled processes.
Currently processes are run by things like `safeSystem`
and `readProcess`, neither of which use a bracketing operation.
But they could use a bracketOnError with an cleanup action that
is passed the pid and kill -9's it.
That avoids the registration and the child thread problem.
"""]]