improve key filenames

This commit is contained in:
Joey Hess 2011-03-15 21:54:38 -04:00
parent 9d49fe2c17
commit f27df5e658

39
Key.hs
View file

@ -35,14 +35,14 @@ stubKey = Key {
} }
fieldSep :: Char fieldSep :: Char
fieldSep = ',' fieldSep = '-'
{- Keys show as strings that are suitable for use as filenames. {- Keys show as strings that are suitable for use as filenames.
- The name field is always shown last, and is the only field - The name field is always shown last, separated by doubled fieldSeps,
- allowed to contain the fieldSep. -} - and is the only field allowed to contain the fieldSep. -}
instance Show Key where instance Show Key where
show Key { keyBackendName = b, keySize = s, keyMtime = m, keyName = n } = show Key { keyBackendName = b, keySize = s, keyMtime = m, keyName = n } =
('b' : b) +++ ('s' ?: s) +++ ('m' ?: m) +++ ('n' : n) b +++ ('s' ?: s) +++ ('m' ?: m) +++ (fieldSep : n)
where where
"" +++ y = y "" +++ y = y
x +++ "" = x x +++ "" = x
@ -53,18 +53,22 @@ instance Show Key where
readKey :: String -> Maybe Key readKey :: String -> Maybe Key
readKey s = if key == Just stubKey then Nothing else key readKey s = if key == Just stubKey then Nothing else key
where where
key = findfields s $ Just stubKey key = startbackend stubKey s
findfields ('n':v) (Just k) = Just $ k { keyName = v } startbackend k v = sepfield k v addbackend
findfields (c:v) (Just k) =
case span (/= fieldSep) v of
(v', _:r) -> findfields r $ addfield k c v'
_ -> Nothing
findfields _ v = v
addfield k 'b' v = Just k { keyBackendName = v } sepfield k v a = case span (/= fieldSep) v of
addfield k 's' v = Just k { keySize = readMaybe v } (v', _:r) -> findfields r $ a k v'
addfield k 'm' v = Just k { keyMtime = readMaybe v } _ -> Nothing
findfields (c:v) (Just k)
| c == fieldSep = Just $ k { keyName = v }
| otherwise = sepfield k v $ addfield c
findfields _ v = v
addbackend k v = Just k { keyBackendName = v }
addfield 's' k v = Just k { keySize = readMaybe v }
addfield 'm' k v = Just k { keyMtime = readMaybe v }
addfield _ _ _ = Nothing addfield _ _ _ = Nothing
-- for quickcheck -- for quickcheck
@ -73,7 +77,12 @@ instance Arbitrary Key where
n <- arbitrary n <- arbitrary
b <- elements ['A'..'Z'] b <- elements ['A'..'Z']
s <- arbitrary s <- arbitrary
return $ Key { keyName = n, keyBackendName = [b] , keySize = s } return $ Key {
keyName = n,
keyBackendName = [b],
keySize = s,
keyMtime = Nothing
}
prop_idempotent_key_read_show :: Key -> Bool prop_idempotent_key_read_show :: Key -> Bool
prop_idempotent_key_read_show k = Just k == (readKey $ show k) prop_idempotent_key_read_show k = Just k == (readKey $ show k)