add thread id field to transferinfo

Also converted its timestand to posix seconds, like is used in the other
log files.
This commit is contained in:
Joey Hess 2012-07-18 18:42:41 -04:00
parent f520a2c103
commit eea0a3616c
4 changed files with 25 additions and 17 deletions

View file

@ -12,8 +12,6 @@ import qualified Annex
import Control.Concurrent
import Data.Tuple
import System.Posix.Types
import System.Posix.Process
{- The Annex state is stored in a MVar, so that threaded actions can access
- it. -}
@ -39,14 +37,14 @@ withThreadState a = do
runThreadState :: ThreadState -> Annex a -> IO a
runThreadState mvar a = modifyMVar mvar $ \state -> swap <$> Annex.run state a
{- Runs an Annex action in a separate process, using a copy of the state
{- Runs an Annex action in a separate thread, using a copy of the state
- from the MVar.
-
- It's up to the action to perform any necessary shutdown tasks in order
- for state to not be lost. And it's up to the caller to resynchronise
- with any changes the action makes to eg, the git-annex branch.
-}
unsafeForkProcessThreadState :: ThreadState -> Annex a -> IO ProcessID
unsafeForkProcessThreadState mvar a = do
unsafeForkIOThreadState :: ThreadState -> Annex a -> IO ThreadId
unsafeForkIOThreadState mvar a = do
state <- readMVar mvar
forkProcess $ void $ Annex.eval state a
forkIO $ void $ Annex.eval state a

View file

@ -18,6 +18,7 @@ import Logs.Location
import Annex.Content
import qualified Remote
import Data.Time.Clock.POSIX
import Data.Time.Clock
import qualified Data.Map as M
@ -58,12 +59,12 @@ shouldTransfer dstatus t info =
| otherwise = return False
key = transferKey t
{- A transfer is run in a separate process, with a *copy* of the Annex
{- A transfer is run in a separate thread, with a *copy* of the Annex
- state. This is necessary to avoid blocking the rest of the assistant
- on the transfer completing, and also to allow multiple transfers to run
- at once.
- at once. This requires GHC's threaded runtime to work!
-
- However, it means that the transfer processes are responsible
- The copy of state means that the transfer processes are responsible
- for doing any necessary shutdown cleanups, and that the parent
- thread's cache must be invalidated once a transfer completes, as
- changes may have been made to the git-annex branch.
@ -73,15 +74,14 @@ runTransfer st dstatus slots t info = case (transferRemote info, associatedFile
(Nothing, _) -> noop
(_, Nothing) -> noop
(Just remote, Just file) -> do
pid <- inTransferSlot slots $
unsafeForkProcessThreadState st $
tid <- inTransferSlot slots $
unsafeForkIOThreadState st $
transferprocess remote file
now <- getCurrentTime
runThreadState st $ adjustTransfers dstatus $
M.insertWith' const t info
{ startedTime = Just now
, transferPid = Just pid
, shouldWait = True
{ startedTime = Just $ utcTimeToPOSIXSeconds now
, transferTid = Just tid
}
where
isdownload = transferDirection t == Download

View file

@ -24,6 +24,7 @@ stubInfo :: AssociatedFile -> TransferInfo
stubInfo f = TransferInfo
{ startedTime = Nothing
, transferPid = Nothing
, transferTid = Nothing
, transferRemote = Nothing
, bytesComplete = Nothing
, associatedFile = f