assistant: Fix deadlock that could occur when adding a lot of files at once in indirect mode.

This is a laziness problem. Despite the bang pattern on newfiles, the list
was not being fully evaluated before cleanup was called. Moving cleanup out
to after the list is actually used fixes this.

More evidence that I should be using ResourceT or pipes, if any was needed.
This commit is contained in:
Joey Hess 2013-07-26 18:42:22 -04:00
parent de066200f3
commit ec4d974dcf
2 changed files with 9 additions and 7 deletions

2
debian/changelog vendored
View file

@ -17,6 +17,8 @@ git-annex (4.20130724) UNRELEASED; urgency=low
transferred.
* assistant: Fix NetWatcher to not sync with remotes that have
remote.<name>.annex-sync set to false.
* assistant: Fix deadlock that could occur when adding a lot of files
at once in indirect mode.
-- Joey Hess <joeyh@debian.org> Tue, 23 Jul 2013 12:39:48 -0400