improve data type

Assistant/Threads/ConfigMonitor.hs

@@ -20,6 +20,7 @@ import Logs.Group
 import Logs.NumCopies
 import Remote.List (remoteListRefresh)
 import qualified Git.LsTree as LsTree
+import Git.Types
 import Git.FilePath
 import qualified Annex.Branch
 
@@ -51,7 +52,7 @@ configMonitorThread = namedThread "ConfigMonitor" $ loop =<< getConfigs
 		loop new
 
 {- Config files, and their checksums. -}
-type Configs = S.Set (FilePath, String)
+type Configs = S.Set (FilePath, Sha)
 
 {- All git-annex's config files, and actions to run when they change. -}
 configFilesActions :: [(FilePath, Assistant ())]

CmdLine/Seek.hs

@@ -80,7 +80,7 @@ withFilesInRefs a = mapM_ go
 		(l, cleanup) <- inRepo $ LsTree.lsTree (Git.Ref r)
 		forM_ l $ \i -> do
 			let f = getTopFilePath $ LsTree.file i
-			v <- catKey (Git.Ref $ LsTree.sha i)
+			v <- catKey (LsTree.sha i)
 			case v of
 				Nothing -> noop
 				Just k -> whenM (matcher $ MatchingKey k) $

Database/Keys.hs

@@ -221,7 +221,7 @@ scanAssociatedFiles = whenM (isJust <$> inRepo Git.Branch.current) $
 		forM_ l $ \i -> 
 			when (isregfile i) $
 				maybe noop (add h i)
-					=<< catKey (Git.Types.Ref $ Git.LsTree.sha i)
+					=<< catKey (Git.LsTree.sha i)
 		liftIO $ void cleanup
   where
 	dropallassociated = queueDb $

Git/LsTree.hs

@@ -26,7 +26,7 @@ import System.Posix.Types
 data TreeItem = TreeItem
 	{ mode :: FileMode
 	, typeobj :: String
-	, sha :: String
+	, sha :: Ref
 	, file :: TopFilePath
 	} deriving Show
 
@@ -66,7 +66,7 @@ parseLsTree :: String -> TreeItem
 parseLsTree l = TreeItem 
 	{ mode = fst $ Prelude.head $ readOct m
 	, typeobj = t
-	, sha = s
+	, sha = Ref s
 	, file = asTopFilePath $ Git.Filename.decode f
 	}
   where

Git/Repair.hs

@@ -342,8 +342,8 @@ verifyTree missing treesha r
 	| S.member treesha missing = return False
 	| otherwise = do
 		(ls, cleanup) <- pipeNullSplit (LsTree.lsTreeParams treesha []) r
-		let objshas = map (extractSha . LsTree.sha . LsTree.parseLsTree) ls
-		if any isNothing objshas || any (`S.member` missing) (catMaybes objshas)
+		let objshas = map (LsTree.sha . LsTree.parseLsTree) ls
+		if any (`S.member` missing) objshas
 			then do
 				void cleanup
 				return False