mirrors/git-annex
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

avoid setEnv while testing gpg

Browse source 
setEnv is not thread safe and could cause a getEnv by another thread to
segfault, or perhaps other had behavior.

Sponsored-by: Dartmouth College's Datalad project
This commit is contained in:
Joey Hess 2022-05-18 15:32:40 -04:00
parent 4ba7a97d8c
commit ebb76f0486
No known key found for this signature in database
GPG key ID: DB12DB0FF05F8F38
5 changed files with 89 additions and 75 deletions
Download patch file Download diff file Expand all files Collapse all files

2
doc/todo/test_suite_unsafe_use_of_setEnv.mdwn
View file

@ -18,3 +18,5 @@ toplevel MVar would be ok, since tests don't run concurrently?
There is also Utility.Gpg.testHarness, which sets GNUPGHOME. It seems that
instead, every place that git-annex is run inside the gpg test harness
would need to add GNUPGHOME to the environment of the git-annex process.
> Fixed this part to not setEnv. --[[Joey]]