remove Params constructor from Utility.SafeCommand
This removes a bit of complexity, and should make things faster (avoids tokenizing Params string), and probably involve less garbage collection. In a few places, it was useful to use Params to avoid needing a list, but that is easily avoided. Problems noticed while doing this conversion: * Some uses of Params "oneword" which was entirely unnecessary overhead. * A few places that built up a list of parameters with ++ and then used Params to split it! Test suite passes.
This commit is contained in:
parent
8f4860df13
commit
eb33569f9d
26 changed files with 221 additions and 118 deletions
|
@ -44,7 +44,8 @@ rsyncServerParams =
|
|||
-- allow resuming of transfers of big files
|
||||
, Param "--inplace"
|
||||
-- other options rsync normally uses in server mode
|
||||
, Params "-e.Lsf ."
|
||||
, Param "-e.Lsf"
|
||||
, Param "."
|
||||
]
|
||||
|
||||
rsyncUseDestinationPermissions :: CommandParam
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue