mirrors/git-annex
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

bug

Browse source
This commit is contained in:
Joey Hess 2019-08-15 12:37:12 -04:00
parent 37f5f00923
commit e6c7778345
No known key found for this signature in database
GPG key ID: DB12DB0FF05F8F38
1 changed files with 19 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

19
doc/bugs/versioned_S3_generates_invalid_encoded_url.mdwn Normal file
View file

@ -0,0 +1,19 @@
See https://github.com/OpenNeuroOrg/datalad-service/issues/99
where the url generated by a versioned S3 export remote did not url-encode
the "+" in the S3 object ID.
This breaks git-annex info's display of urls for a file.
It also breaks git-annex get from a public S3 remote. While the object
in that issue is versioned, other code paths for non-versioned objects
have the same problem.
https://docs.aws.amazon.com/AmazonS3/latest/API/sig-v4-header-based-auth.html
describes an URI encoding that appears non-standard;
Aws.S3.Core.s3UriEncode implements that. But is S3 using the same
non-standard URI encoding for URLs to objects?
https://docs.aws.amazon.com/AmazonS3/latest/dev/UsingMetadata.html
documents a need to url-encode a few punctuation characters, but is
frustratingly vague.
Experimentally, even url-encoding alphanumerics works in these urls.
So it would be ok to use a standard URI encoder.