From e223ddb774398be2be4fef6ce0a1df8359ae4bed Mon Sep 17 00:00:00 2001 From: Joey Hess Date: Mon, 13 Jul 2020 17:52:03 -0400 Subject: [PATCH] comments --- ..._282d1a5a2942820785b9cdacc1126545._comment | 20 +++++++++++++++++++ ..._4ddca3bdc573ed3c7f6d846c4309ac2e._comment | 10 ++++++++++ 2 files changed, 30 insertions(+) create mode 100644 doc/bugs/Recent_hang_with_rsync_remote_with_older_systems___40__Xenial__44___Jessie__41__/comment_4_282d1a5a2942820785b9cdacc1126545._comment create mode 100644 doc/bugs/SSH-based_git-annex-init_hang_on_older_systems___40__Xenial__44___Jessie__41__/comment_3_4ddca3bdc573ed3c7f6d846c4309ac2e._comment diff --git a/doc/bugs/Recent_hang_with_rsync_remote_with_older_systems___40__Xenial__44___Jessie__41__/comment_4_282d1a5a2942820785b9cdacc1126545._comment b/doc/bugs/Recent_hang_with_rsync_remote_with_older_systems___40__Xenial__44___Jessie__41__/comment_4_282d1a5a2942820785b9cdacc1126545._comment new file mode 100644 index 0000000000..8082ddf944 --- /dev/null +++ b/doc/bugs/Recent_hang_with_rsync_remote_with_older_systems___40__Xenial__44___Jessie__41__/comment_4_282d1a5a2942820785b9cdacc1126545._comment @@ -0,0 +1,20 @@ +[[!comment format=mdwn + username="joey" + subject="""comment 4""" + date="2020-07-13T21:15:46Z" + content=""" +If rsync is truely what's hanging, then commit 4c9ad1de4 can't have changed +anything to do with that. Seems more likely that the hang did not actually +involve rsync (but the debug output makes it seem like it is), +or that the hang is not fully deterministic. + +Whatever it's hanging on in the first patch is apparently not involving +rsync, because rsync has exited. And it doesn't make sense that the first +patch would hang while the second one doesn't, they're doing identical +things except for extra background thread cleanup in the second patch. + +As this stands, I don't feel confident enough that the second patch really +fixes this to close this. Also I'm a little bit doubtful it's really +correct, it seems possible it might cancel one of the threads before all +output is processed by them. The first patch actually seems better. +"""]] diff --git a/doc/bugs/SSH-based_git-annex-init_hang_on_older_systems___40__Xenial__44___Jessie__41__/comment_3_4ddca3bdc573ed3c7f6d846c4309ac2e._comment b/doc/bugs/SSH-based_git-annex-init_hang_on_older_systems___40__Xenial__44___Jessie__41__/comment_3_4ddca3bdc573ed3c7f6d846c4309ac2e._comment new file mode 100644 index 0000000000..7272622072 --- /dev/null +++ b/doc/bugs/SSH-based_git-annex-init_hang_on_older_systems___40__Xenial__44___Jessie__41__/comment_3_4ddca3bdc573ed3c7f6d846c4309ac2e._comment @@ -0,0 +1,10 @@ +[[!comment format=mdwn + username="joey" + subject="""comment 3""" + date="2020-07-13T21:20:19Z" + content=""" +Ok, but the results for similar patches in + +make me somewhat doubt I understand the problem, or that these hangs +are fully deterministic. +"""]]