mirrors/git-annex
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

optimisation

Browse source 
IORef rather than MVar sped up benchmark mentioned in last commit to
13.0s.

This makes me wonder if changing the interface to not need the IORef
either would improve speed further.
This commit is contained in:
Joey Hess 2021-02-10 16:38:33 -04:00
parent f44d4704c6
commit dc9376feeb
No known key found for this signature in database
GPG key ID: DB12DB0FF05F8F38
1 changed files with 4 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
Backend/Hash.hs
View file

@ -28,7 +28,7 @@ import qualified Data.ByteString.Char8 as S8
import qualified Data.ByteString.Lazy as L import qualified Data.ByteString.Lazy as L
import Control.DeepSeq import Control.DeepSeq
import Control.Exception (evaluate) import Control.Exception (evaluate)
import Control.Concurrent.MVar import Data.IORef
data Hash data Hash
= MD5Hash = MD5Hash
@ -280,15 +280,11 @@ md5Hasher = mkHasher md5 md5_context
mkIncrementalVerifier :: HashAlgorithm h => Context h -> Key -> IO IncrementalVerifier mkIncrementalVerifier :: HashAlgorithm h => Context h -> Key -> IO IncrementalVerifier
mkIncrementalVerifier ctx key = do mkIncrementalVerifier ctx key = do
v <- newMVar ctx v <- newIORef ctx
return $ IncrementalVerifier return $ IncrementalVerifier
{ updateIncremental = \b -> do { updateIncremental = modifyIORef' v . flip hashUpdate
ctx' <- takeMVar v
let ctx'' = hashUpdate ctx' b
evaluate $ rnf ctx''
putMVar v ctx''
, finalizeIncremental = do , finalizeIncremental = do
ctx' <- takeMVar v ctx' <- readIORef v
let digest = hashFinalize ctx' let digest = hashFinalize ctx'
return $ sameCheckSum key (show digest) return $ sameCheckSum key (show digest)
} }