ssh transport seems ready, needs testing

This commit is contained in:
Joey Hess 2014-04-12 18:39:50 -04:00
parent ff192ace2f
commit da253358b7

View file

@ -162,26 +162,7 @@ over stdio to inform when refs on the remote have changed.
No pushing is done for CHANGED, since git handles ssh natively.
TODO:
* Remote system might not be available. Find a smart way to detect it,
ideally w/o generating network traffic. One way might be to check
if the ssh connection caching control socket exists, for example.
* Now that ssh connection caching is enabled for git push/pull in sync,
there's the possibility that a stale ssh connection may linger when
changing network connections, and so attempts to use it will stall.
(This was already a potential issue with transfers, which already
used the caching.)
One option is ssh's ServerAliveCountMax, which will make a dead
ssh connection disconnect after approx 45 seconds, per ssh manual.
It would need to be enabled by setting ServerAliveInterval=15.
And this would add network traffic..
Another option is to disable all cached connections when the network
connection changes. This would handle *most* cases. The case
not handled is eg, my dialup ppp box getting a new public IP address,
which my laptop won't notice. **done**
TODO: test!
## telehash