mirrors/git-annex
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

analysis; forwarded

Browse source
This commit is contained in:
Joey Hess 2015-08-03 11:27:27 -04:00
parent d82b755a4f
commit d986d24494
2 changed files with 28 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
Utility/DirWatcher/INotify.hs
View file

@ -102,7 +102,8 @@ watchDir i dir ignored scanevents hooks
| Files.isSymbolicLink s ->
when (hashook addSymlinkHook) $
runhook addSymlinkHook f ms
| Files.isRegularFile s ->
| Files.isRegularFile s -> do
print ("ADDED")
when (hashook addHook) $
runhook addHook f ms
_ -> noop

26
doc/bugs/Error_writing_log_message_when_filename_contains_Unicode_chars/comment_2_1be17780fd4244053c504383ad56969b._comment Normal file
View file

@ -0,0 +1,26 @@
[[!comment format=mdwn
username="joey"
subject="""comment 2"""
date="2015-08-03T14:33:38Z"
content="""
I was able to reproduce this, but only once I started the assistant with
LANG=C. I suspect that the bug reporter's locale in the shell is not
the locale the assistant was started with.
(Also, I included the French quotes in the filename, which wasn't very
clear in the bug report.)
The failure to output a debug message is not actually fatal. The file
still gets added and committed if it exists when the assistant starts up,
despite this "error". What actually seems to be failing is the
inotify code. Creating the file while the assistant is running with LANG=C
results in no inotify event being received for it. AFAICS, the
inotify library is falling over on the filename, before git-annex ever gets
to see the file.
Hmm, it looks like the inotify library is generating events with
filenames that have high bit characters stripped out when run in the C
locale! So, git-annex gets an event for a file that's not present, and
ignores it. This sure seems like a bug in the inotify library to me. Bug
filed: <https://github.com/kolmodin/hinotify/issues/13>.
"""]]