mirrors/git-annex
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

comments

Browse source
This commit is contained in:
Joey Hess 2021-03-23 12:05:05 -04:00
parent e09560eea2
commit d89a9b0f78
No known key found for this signature in database
GPG key ID: DB12DB0FF05F8F38
2 changed files with 36 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

26
doc/todo/Avoid_lengthy___34__Scanning_for_unlocked_files_...__34__/comment_3_c3f029b865bcd489d03bcf722dfa4e44._comment Normal file
View file

@ -0,0 +1,26 @@
[[!comment format=mdwn
username="joey"
subject="""comment 3"""
date="2021-03-23T15:54:18Z"
content="""
The idea of putting a flag in the git-annex branch means that every time
the smudge filter gets run, it would have to check the git-annex branch to
see if it needs to unset that flag. I do not want to make the smudge filter
even slower than it is, and trading off a one-time (per repository) cost
with an ongoing cost does not seem good.
The flag would also be a source of problems in complex
situations. Eg, someone could be operating on the repo w/o git-annex
installed, merge in a branch that contains unlocked files, and push the
result. Leading to the flag in the git-annex branch being left incorrectly
set, and so causing breakage to someone who clones the repo later on.
Also, a transient unlock/modify/add of a file leaves no unlocked files in
the worktree, but the unlock would set the flag, so any performance benefit
would need all users of the repo to avoid such workflows.
So viable approaches seem to be to optimise the scanning as much as
possible, and possibly to add some config to git-annex that avoids doing
the scanning, which could be used if you happen to know your repo doesn't
contain unlocked files.
"""]]

10
doc/todo/only_pass_unlocked_files_through_the_clean__47__smudge_filter/comment_5_7a5e4fd5859a5ec879746697fb720d43._comment Normal file
View file

@ -0,0 +1,10 @@
[[!comment format=mdwn
username="joey"
subject="""comment 5"""
date="2021-03-23T16:02:47Z"
content="""
> "the proposal would break this" -- suppose git-annex-unlock was changed to install the clean/smudge filter for * if not installed yet?
git-annex unlock is not the only way unlocked files can appear in your
tree. Consider git pull.
"""]]