mirrors/git-annex
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

use ByteString for git config

Browse source 
The parser and looking up config keys in the map should both be faster
due to using ByteString.

I had hoped this would speed up startup time, but any improvement to
that was too small to measure. Seems worth keeping though.

Note that the parser breaks up the ByteString, but a config map ends up
pointing to the config as read, which is retained in memory until every
value from it is no longer used. This can change memory usage
patterns marginally, but won't affect git-annex.
This commit is contained in:
Joey Hess 2019-11-27 16:54:11 -04:00
parent 37d0f73e66
commit d7833def66
No known key found for this signature in database
GPG key ID: DB12DB0FF05F8F38
27 changed files with 176 additions and 105 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Git/Types.hs
View file

@ -35,9 +35,9 @@ data RepoLocation
data Repo = Repo
{ location :: RepoLocation
, config :: M.Map String String
, config :: M.Map S.ByteString S.ByteString
-- a given git config key can actually have multiple values
, fullconfig :: M.Map String [String]
, fullconfig :: M.Map S.ByteString [S.ByteString]
-- remoteName holds the name used for this repo in some other
-- repo's list of remotes, when this repo is such a remote
, remoteName :: Maybe RemoteName