From a7fe423966a464bf0a91c55453a456baa0450c3c Mon Sep 17 00:00:00 2001 From: Joey Hess Date: Mon, 17 Dec 2012 19:14:47 -0400 Subject: [PATCH 1/3] blog for the day --- .../assistant/blog/day_153__hibernation.mdwn | 26 +++++++++++++++++++ 1 file changed, 26 insertions(+) create mode 100644 doc/design/assistant/blog/day_153__hibernation.mdwn diff --git a/doc/design/assistant/blog/day_153__hibernation.mdwn b/doc/design/assistant/blog/day_153__hibernation.mdwn new file mode 100644 index 0000000000..5406fcb868 --- /dev/null +++ b/doc/design/assistant/blog/day_153__hibernation.mdwn @@ -0,0 +1,26 @@ +As winter clouds set in, I have to ration my solar power and have been less +active than usual. + +It seems that the OSX 10.8.2 `git init` hanging issue has indeed been +resolved, by building the app on 10.8.2. Very good news! Autobuilder setup is +in progress. + +---- + +Finally getting stuck in to direct mode git-merge handling. It's +not possible to run `git merge` in a direct mode tree, because it'll +see typechanged files and refuse to do anything. + +So the only way to use `git merge`, rather than writing my own merge engine, +is to use `--work-tree` to make it operate in a temporary work tree directory +rather than the real one. + +When it's run this way, any new, modified, or renamed files will be added +to the temp dir, and will need to be moved to the real work tree. +To detect deleted files, need to use `git ls-files --others`, and +look at the old tree to see if the listed files were in it. + +When a merge conflict occurs, the new version of the file will be in the temp +directory, and the old one in the work tree. The normal automatic merge +conflict resolution machinery should work, with just some tweaks to handle +direct mode. From 0846d60c3c547928c1bae42f71e48abb9f5c599d Mon Sep 17 00:00:00 2001 From: Joey Hess Date: Mon, 17 Dec 2012 19:47:39 -0400 Subject: [PATCH 2/3] new autobuilder --- doc/install/OSX.mdwn | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/doc/install/OSX.mdwn b/doc/install/OSX.mdwn index 795986176a..e0bfa18f8e 100644 --- a/doc/install/OSX.mdwn +++ b/doc/install/OSX.mdwn @@ -11,11 +11,15 @@ reports. ## autobuilds [Jimmy Tang](http://www.sgenomics.org/~jtang/) autobuilds -the app. These autobuilds only work on OSX Lion, not Mountain Lion. +the app for OSX Lion. * [autobuild of git-annex.app](http://www.sgenomics.org/~jtang/gitbuilder-git-annex-x00-x86_64-apple-darwin10.8.0-binary/ref/master/git-annex.dmg.bz2) ([build logs](http://www.sgenomics.org/~jtang/gitbuilder-git-annex-x00-x86_64-apple-darwin10.8.0-binary/)) * [past builds](http://www.sgenomics.org/~jtang/gitbuilder-git-annex-x00-x86_64-apple-darwin10.8.0-binary/sha1/) -- directories are named from the commitid's +[[Joey]] autobuilds the app for Mountain Lion. + +* [autobuild of git-annex.app](http://downloads.kitenet.net/git-annex/OSX/autobuild/git-annex.dmg.bz2) ([build logs](http://downloads.kitenet.net/git-annex/OSX/autobuild/)) + ## using Brew

From 77931c1e92701530da763176c91c1c6d37d05c7d Mon Sep 17 00:00:00 2001
From: Joey Hess 
Date: Tue, 18 Dec 2012 12:19:24 -0400
Subject: [PATCH 3/3] vicfg: Quote filename. Closes: #696193

---
 Command/Vicfg.hs | 2 +-
 debian/changelog | 1 +
 2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/Command/Vicfg.hs b/Command/Vicfg.hs
index cfe051c4e3..8aefd86bbd 100644
--- a/Command/Vicfg.hs
+++ b/Command/Vicfg.hs
@@ -44,7 +44,7 @@ vicfg :: Cfg -> FilePath -> Annex ()
 vicfg curcfg f = do
 	vi <- liftIO $ catchDefaultIO "vi" $ getEnv "EDITOR"
 	-- Allow EDITOR to be processed by the shell, so it can contain options.
-	unlessM (liftIO $ boolSystem "sh" [Param "-c", Param $ unwords [vi, f]]) $
+	unlessM (liftIO $ boolSystem "sh" [Param "-c", Param $ unwords [vi, shellEscape f]]) $
 		error $ vi ++ " exited nonzero; aborting"
 	r <- parseCfg curcfg <$> liftIO (readFileStrict f)
 	liftIO $ nukeFile f
diff --git a/debian/changelog b/debian/changelog
index a0dd005d16..d83bd7b8b4 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,6 +1,7 @@
 git-annex (3.20121212) UNRELEASED; urgency=low
 
   * kqueue: Fix bug that made broken symlinks not be noticed.
+  * vicfg: Quote filename. Closes: #696193
 
  -- Joey Hess   Fri, 14 Dec 2012 16:25:14 -0400