mirrors/git-annex
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

improve live update starting

Browse source 
In an expression like "balanced=foo and exclude=bar", avoid it starting
a live update when the overall expression doesn't match.
This commit is contained in:
Joey Hess 2024-08-24 13:07:05 -04:00
parent 16f945459c
commit d60a33fd13
No known key found for this signature in database
GPG key ID: DB12DB0FF05F8F38
5 changed files with 67 additions and 47 deletions
Download patch file Download diff file Expand all files Collapse all files

14
doc/todo/git-annex_proxies.mdwn
View file

@ -145,20 +145,6 @@ Planned schedule of work:
* Still implementing LiveUpdate. Check for TODO XXX markers
* In an expression like "balanced=foo and exclude=bar",
it will start a live update even if the overall expression doesn't
match. That is suboptimal, but also this will probably be a rare case,
it doesn't really make sense to to that. What will happen in that case
is the repo will temporarily be treated as having that key going
into it, even when it is not. As soon as the LiveUpdate gets GCed,
that resolves. Until then, other keys may not match that usually would,
if the repo would have been filled up by that key.
What could be done in this case is, after checking preferred content,
when it's not preferred content, call stopLiveUpdate immediately,
rather than relying on GC.
That would also help with the next problem...
* In the case where a copy to a remote fails (due eg to annex.diskreserve),
the LiveUpdate thread can not get a chance to catch its exception when
the LiveUpdate is gced, before git-annex exits. In this case, the