always check numcopies when moving from cluster

When the destination does not start with a copy, the cluster has one or
more copies. If more, dropping would reduce the number of copies, so
numcopies must be checked.

Considered checking how many nodes of the cluster contain a copy. If
only 1 node does, it could allow a move without checking numcopies.
The problem with that, though, is that other nodes of the cluster could
have copies that we don't know about. And dropping from a cluster tries
to drop from all nodes, so will drop even from those. So any drop from a
cluster can remove more than 1 copy.
This commit is contained in:
Joey Hess 2024-06-23 12:00:50 -04:00
parent ec5b6454f4
commit d0aec8f623
No known key found for this signature in database
GPG key ID: DB12DB0FF05F8F38
2 changed files with 5 additions and 7 deletions

View file

@ -67,10 +67,6 @@ For June's work on [[design/passthrough_proxy]], implementation plan:
protocol. (done, but need to check for fencepost errors on resume of
incomplete upload with remotes at different points)
* Problem: `move --from cluster` in "does this make it worse"
check may fail to realize that dropping from multiple nodes does in fact
make it worse.
* `git-annex sync --content` does not send content to clusters, or to
proxied remotes. And when operating on clusters, it should operate on the
cluster as a whole, not on cluster nodes.