mirrors/git-annex
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

closed a race, although a less likely similar one remains

Browse source
This commit is contained in:
Joey Hess 2012-06-05 20:34:25 -04:00
parent c981ccc077
commit d05a22b5f6
1 changed files with 11 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

16
doc/design/assistant/inotify.mdwn
View file

@ -58,12 +58,18 @@ Many races need to be dealt with by this code. Here are some of them.
* File is added and then replaced with another file before the annex add * File is added and then replaced with another file before the annex add
moves its content into the annex. moves its content into the annex.
**Currently unfixed**; The new content will be moved to the annex under the Fixed this problem; Now it hard links the file to a temp directory and
old checksum, and fsck will later catch this inconsistency. operates on the hard link, which is also made unwritable.
Possible fix: Move content someplace before doing checksumming. Perhaps * A process has a file open for write, another one closes it, and so it's
using a hard link and removing the write bit to prevent modification added. Then the first process modifies it.
while checksumming.
**Currently unfixed**; This changes content in the annex, and fsck will
later catch the inconsistency.
Possible fixes: Somehow track or detect if a file is open for write
by any processes. Or, when possible, making a copy on write copy
before adding the file would avoid this.
* File is added and then replaced with another file before the annex add * File is added and then replaced with another file before the annex add
makes its symlink. makes its symlink.