mirrors/git-annex
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

use insert_ for speed improvement

Browse source 
persistent-2.14.4.1 makes insert_ faster than insert because it skips
getting the key back.

Sponsored-by: Dartmouth College's DANDI project
This commit is contained in:
Joey Hess 2022-12-26 15:18:55 -04:00
parent aa041596f5
commit cf892f4256
No known key found for this signature in database
GPG key ID: DB12DB0FF05F8F38
2 changed files with 19 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
Database/Keys/SQL.hs
View file

@ -93,7 +93,7 @@ addAssociatedFile k f = queueDb $
-- any old key. -- any old key.
newAssociatedFile :: Key -> TopFilePath -> WriteHandle -> IO () newAssociatedFile :: Key -> TopFilePath -> WriteHandle -> IO ()
newAssociatedFile k f = queueDb $ newAssociatedFile k f = queueDb $
void $ insert $ Associated k af insert_ $ Associated k af
where where
af = SFilePath (getTopFilePath f) af = SFilePath (getTopFilePath f)

18
doc/bugs/performance_regression__63___init_takes_times_more/comment_17_d13e85f691165b533d6630a93111c786._comment Normal file
View file

@ -0,0 +1,18 @@
[[!comment format=mdwn
username="joey"
subject="""comment 17"""
date="2022-12-26T19:10:04Z"
content="""
<https://github.com/yesodweb/persistent/issues/1441> got fixed in
persistent-2.14.4.1. git-annex will get that speed improvement when it's
built with that version. I'd anticipate it improving from 19 seconds
to around 16 seconds.
(I further opened <https://github.com/yesodweb/persistent/issues/1457>
that would speed up some other parts of git-annex if implemented.)
---
The only reason to leave this bug open is that reconcileStaged is still
somehow slower than only the persistent-sqlite overhead can explain.
"""]]