mirrors/git-annex
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

analysis

Browse source
This commit is contained in:
Joey Hess 2020-08-25 14:31:15 -04:00
parent 2b6fc17f70
commit ca3fb4b1d2
No known key found for this signature in database
GPG key ID: DB12DB0FF05F8F38
1 changed files with 22 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

22
doc/bugs/get_is_stuck_unless_a_clone_was_previously_explicitly___34__annex_init__34__ed/comment_4_b2c7517a7482071111514a68c70ce8dc._comment Normal file
View file

@ -0,0 +1,22 @@
[[!comment format=mdwn
username="joey"
subject="""comment 4"""
date="2020-08-25T17:44:43Z"
content="""
This is the same class of bug as
[[!commit 82448bdf39bbe2b4fb6e0bac0735b845d52e189a]] fixed.
Subsequent to that fix, I audited for other bugs in this class
and tried to fix them too
in [[!commit 96f6aa39dda335bf9aa25ed8a67756e31bd307c2]].
What that commit missed was that runsGitAnnexChildProcess only
affects running git commands, while actually in all 3 places touched by
that commit, git-annex runs other, non-git commands that result in git-annex
being run. So all 3 of those can still deadlock like this, and actually
that commit made it worse by making them always deadlock, rather than only
theoretically deadlock in some case where some other part of git-annex
happened to have taken the pid lock at the same time.
(Not really deadlock, I think, but wait for the annex.pidlocktimeout
and then fail after 5 minutes.)
"""]]