mirrors/git-annex
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

Fix retrieval of content from borg repos accessed over ssh

Browse source 
It was making the borgrepo path absolute.. even when it was a ssh
repository.

Made BorgRepo a newtype, to guard against accidentially treating it like a
FilePath.

Sponsored-by: Graham Spencer on Patreon
This commit is contained in:
Joey Hess 2021-07-15 12:38:55 -04:00
parent b2a7a665b2
commit c952c485c8
No known key found for this signature in database
GPG key ID: DB12DB0FF05F8F38
4 changed files with 42 additions and 12 deletions
Download patch file Download diff file Expand all files Collapse all files

2
doc/bugs/content_retrieval_from_borg_remote_fails_over_ssh.mdwn
View file

@ -71,3 +71,5 @@ NOTE: I tried several variations of the ssh url syntax, but they all resulted in
### Have you had any luck using git-annex before? (Sometimes we get tired of reading bug reports all day and a lil' positive end note does wonders)
Definitely. I love git-annex. I LOVE it. It has no equal and is the secret to my productivity, not to mention peace of mind in this epoch. Much, much respect.
> [[fixed|done]] --[[Joey]]

15
doc/bugs/content_retrieval_from_borg_remote_fails_over_ssh/comment_1_050cb1054a9d1cc7b2e6722757c41784._comment Normal file
View file

@ -0,0 +1,15 @@
[[!comment format=mdwn
username="joey"
subject="""comment 1"""
date="2021-07-15T16:20:33Z"
content="""
Thanks for a good repo recipe. I only needed to add a "borg init
$BORG_REPO -e none" to see the bug.
The bug is because it had to make the path to the borg repo absolute,
since it's running borg inside a temp directory. And the case of a ssh
location was not considered when doing that.
Fixed and cleaned up the BorgRepo data type to avoid this kind of dumb
mistake in the future. ;-)
"""]]