mirrors/git-annex
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

comment

Browse source
This commit is contained in:
Joey Hess 2024-10-15 13:27:27 -04:00
parent c1b0348307
commit c6c794a27d
No known key found for this signature in database
GPG key ID: DB12DB0FF05F8F38
2 changed files with 22 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
Remote/Directory.hs
View file

@ -252,9 +252,9 @@ finalizeStoreGeneric d tmp dest = do
retrieveKeyFileM :: RawFilePath -> ChunkConfig -> CopyCoWTried -> Retriever retrieveKeyFileM :: RawFilePath -> ChunkConfig -> CopyCoWTried -> Retriever
retrieveKeyFileM d (LegacyChunks _) _ = Legacy.retrieve locations' d retrieveKeyFileM d (LegacyChunks _) _ = Legacy.retrieve locations' d
retrieveKeyFileM d NoChunks cow = fileRetriever' $ \dest k p iv -> do --retrieveKeyFileM d NoChunks cow = fileRetriever' $ \dest k p iv -> do
src <- liftIO $ fromRawFilePath <$> getLocation d k -- src <- liftIO $ fromRawFilePath <$> getLocation d k
void $ liftIO $ fileCopier cow src (fromRawFilePath dest) p iv -- void $ liftIO $ fileCopier cow src (fromRawFilePath dest) p iv
retrieveKeyFileM d _ _ = byteRetriever $ \k sink -> retrieveKeyFileM d _ _ = byteRetriever $ \k sink ->
sink =<< liftIO (L.readFile . fromRawFilePath =<< getLocation d k) sink =<< liftIO (L.readFile . fromRawFilePath =<< getLocation d k)

19
doc/bugs/p2phttp__58___drop_difference_wideopen_unauth-readonly/comment_3_83dc4e317e09ad1e24fdd3ee347edb43._comment Normal file
View file

@ -0,0 +1,19 @@
[[!comment format=mdwn
username="joey"
subject="""comment 3"""
date="2024-10-15T16:33:06Z"
content="""
It's not a special case about locking. p2phttp always uses 403 when
the mode it's serving does not allow the class of action.
Eg with --unauth-appendonly a remove request will cause a 403 response.
And with --unauth-readonly any non-read request does.
The docs say:
"When authentication is successful but does not allow a request to be
performed, it will fail with 403 Forbidden."
A 401 does make git-annex prompt for a password. p2phttp responds to that
when --authenv is used and the client didn't basic authenticate.
"""]]