mirrors/git-annex
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

webapp: Fixed a crash when adding a git remote.

Browse source 
Reversion introduced in 2b66492d6e which added a new cache that needs to be
cleared.
This commit is contained in:
Joey Hess 2018-10-29 16:01:08 -04:00
parent 3beab402e6
commit c472c268c4
No known key found for this signature in database
GPG key ID: DB12DB0FF05F8F38
4 changed files with 24 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
CHANGELOG
View file

@ -49,6 +49,8 @@ git-annex (7.20181025) UNRELEASED; urgency=medium
* addurl: Removed undocumented special case in handling of a CHECKURL-MULTI * addurl: Removed undocumented special case in handling of a CHECKURL-MULTI
response with only a single file listed. Rather than ignoring the url that response with only a single file listed. Rather than ignoring the url that
was in the response, use it. was in the response, use it.
* webapp: Fixed a crash when adding a git remote.
(Reversion introduced in version 6.20180112)
-- Joey Hess <id@joeyh.name> Sat, 13 Oct 2018 00:52:02 -0400 -- Joey Hess <id@joeyh.name> Sat, 13 Oct 2018 00:52:02 -0400

1
Remote/List.hs
View file

@ -93,6 +93,7 @@ remoteListRefresh = do
newg <- inRepo Git.Config.reRead newg <- inRepo Git.Config.reRead
Annex.changeState $ \s -> s Annex.changeState $ \s -> s
{ Annex.remotes = [] { Annex.remotes = []
, Annex.gitremotes = Nothing
, Annex.repo = newg , Annex.repo = newg
} }
remoteList remoteList

1
doc/bugs/Can__39__t_add_remotes_through_the_web_assistant.mdwn
View file

@ -108,3 +108,4 @@ The interesting part here is that if I try to run the failing git commands in th
### Have you had any luck using git-annex before? (Sometimes we get tired of reading bug reports all day and a lil' positive end note does wonders) ### Have you had any luck using git-annex before? (Sometimes we get tired of reading bug reports all day and a lil' positive end note does wonders)
I have been using it for years. Just not the webapp :) I have been using it for years. Just not the webapp :)
> [[fixed|done]] --[[Joey]]

20
doc/bugs/Can__39__t_add_remotes_through_the_web_assistant/comment_8_4415e7897cca54e004f3cb06031753ae._comment Normal file
View file

@ -0,0 +1,20 @@
[[!comment format=mdwn
username="joey"
subject="""comment 8"""
date="2018-10-29T19:36:51Z"
content="""
Sorry for leaving such a bad bug unaddressed so long. (And in fact a
reversion since it used to work fine and I broke it about a month before
this bug was opened.)
It's fixed now.
Bear in mind that I have a backlog that is literally
over 400 items long and just can't get to everything promptly.
Unsure why I didn't notice one of the several followups in my
triage operations, other than the assistant being a ways down
my prority list and bug reports about it often being not detailed enough
and taking a lot of time to understand. If anyone would like to help
triage out important problems like this one that I may be missing,
that would be great.
"""]]