mirrors/git-annex
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

make storeKey throw exceptions

Browse source 
When storing content on remote fails, always display a reason why.

Since the Storer used by special remotes already did, this mostly affects
git remotes, but not entirely. For example, if git-lfs failed to connect to
the endpoint, it used to silently return False.
This commit is contained in:
Joey Hess 2020-05-13 14:03:00 -04:00
parent b50ee9cd0c
commit c1cd402081
No known key found for this signature in database
GPG key ID: DB12DB0FF05F8F38
34 changed files with 214 additions and 197 deletions
Download patch file Download diff file Expand all files Collapse all files

3
doc/bugs/filenames_with_dots_and_spaces_can_not_be_exported.mdwn
View file

@ -13,3 +13,6 @@ I am not yet sure what exact combinations of dots, spaces and maybe dashes cause
### What version of git-annex are you using? On what operating system?
git-annex version: 8.20200309-05df404212, Debian testing
[[!meta title="change exception handling of remotes to avoid ever failing
without telling the reason why"]]

12
doc/bugs/filenames_with_dots_and_spaces_can_not_be_exported/comment_3_d386ca19d803fc6d1c720d0188f00fec._comment Normal file
View file

@ -0,0 +1,12 @@
[[!comment format=mdwn
username="joey"
subject="""comment 3"""
date="2020-05-13T17:58:49Z"
content="""
Converted the storeKey method to throw exceptions. This was a 1000 line
patch, 3 hours of work. Seems likely it will take 24 hours work to finish
converting all the methods..
There were quite a few places where it used to return False without
displaying a reason for the failure, so the work seems worth it.
"""]]