make storeKey throw exceptions
When storing content on remote fails, always display a reason why. Since the Storer used by special remotes already did, this mostly affects git remotes, but not entirely. For example, if git-lfs failed to connect to the endpoint, it used to silently return False.
This commit is contained in:
parent
b50ee9cd0c
commit
c1cd402081
34 changed files with 214 additions and 197 deletions
|
@ -13,3 +13,6 @@ I am not yet sure what exact combinations of dots, spaces and maybe dashes cause
|
|||
### What version of git-annex are you using? On what operating system?
|
||||
|
||||
git-annex version: 8.20200309-05df404212, Debian testing
|
||||
|
||||
[[!meta title="change exception handling of remotes to avoid ever failing
|
||||
without telling the reason why"]]
|
||||
|
|
|
@ -0,0 +1,12 @@
|
|||
[[!comment format=mdwn
|
||||
username="joey"
|
||||
subject="""comment 3"""
|
||||
date="2020-05-13T17:58:49Z"
|
||||
content="""
|
||||
Converted the storeKey method to throw exceptions. This was a 1000 line
|
||||
patch, 3 hours of work. Seems likely it will take 24 hours work to finish
|
||||
converting all the methods..
|
||||
|
||||
There were quite a few places where it used to return False without
|
||||
displaying a reason for the failure, so the work seems worth it.
|
||||
"""]]
|
Loading…
Add table
Add a link
Reference in a new issue