make storeExport atomic

This avoids needing to deal with the complexity of partially transferred
files in the export. We'd not be able to resume uploading to such a file
anyway, so just avoid them.

The implementation in Remote.Directory is not completely ideal, because
it could leave the temp file hanging around in the export directory.
This only happens if it's killed with -9, or there's a power failure;
normally viaTmp cleans up after itself, even when interrupted. I could
not see a better way to do it though, since the export directory might
be the root of a filesystem.

Also some design thoughts on resuming, which depend on storeExport being
atomic.

This commit was sponsored by Fernando Jimenez on Partreon.
This commit is contained in:
Joey Hess 2017-08-31 14:24:32 -04:00
parent 7c7af82578
commit bb08b1abd2
No known key found for this signature in database
GPG key ID: DB12DB0FF05F8F38
4 changed files with 50 additions and 41 deletions

View file

@ -98,7 +98,8 @@ data RemoteA a = Remote {
checkPresentCheap :: Bool,
-- Exports content to an ExportLocation.
-- The exported file does not need to be updated atomically.
-- The exported file should not appear to be present on the remote
-- until all of its contents have been transferred.
storeExport :: Maybe (FilePath -> Key -> ExportLocation -> MeterUpdate -> a Bool),
-- Retrieves exported content to a file.
-- (The MeterUpdate does not need to be used if it writes