mirrors/git-annex
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

assistant: Fixed several minor memory leaks that manifested when adding a large number of files.

Browse source
This commit is contained in:
Joey Hess 2014-01-05 21:30:48 -04:00
parent 404c750489
commit b92b54bd42
9 changed files with 39 additions and 19 deletions
Download patch file Download diff file Expand all files Collapse all files

10
doc/bugs/import_memleak_from_the_assistant.mdwn
View file

@ -1596,3 +1596,13 @@ rsync error: error in rsync protocol data stream (code 12) at io.c(605) [sender=
# End of transcript or log.
"""]]
> [[Fixed|done]]. This was several garden-variety haskell laziness leaks,
> all fixed by adding strictness annotations.
>
> Before: [[leakbefore.png]]
> After: [[leakafter.png]]
>
> Looks like I got them all, and it returns to running in constant space
> after adding and uploading the files (which can take memory porportional
> to the number of files that were added/changed at once). --[[Joey]]

BIN
doc/bugs/import_memleak_from_the_assistant/leakafter.png Normal file
View file

Binary file not shown.
Side by side

After

Width:  |  Height:  |  Size: 42 KiB

BIN
doc/bugs/import_memleak_from_the_assistant/leakbefore.png Normal file
View file

Binary file not shown.
Side by side

After

Width:  |  Height:  |  Size: 23 KiB