From b26ee162f33858aa4ef82fbe3d56eecc00590755 Mon Sep 17 00:00:00 2001 From: Joey Hess Date: Sat, 27 Aug 2011 12:34:02 -0400 Subject: [PATCH] guess not everyone configures their shell to show nonzero exit codes.. --- Makefile | 4 +++- doc/bugs/test_suite_shouldn__39__t_fail_silently.mdwn | 2 ++ 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/Makefile b/Makefile index fa087c1ae2..20d1347140 100644 --- a/Makefile +++ b/Makefile @@ -53,7 +53,9 @@ test: $(bins) @if ! $(GHCMAKE) -O0 test; then \ echo "** not running test suite" >&2; \ else \ - ./test; \ + if ! ./test; then \ + echo "** test suite failed!" >&2; \ + fi; \ fi testcoverage: $(bins) diff --git a/doc/bugs/test_suite_shouldn__39__t_fail_silently.mdwn b/doc/bugs/test_suite_shouldn__39__t_fail_silently.mdwn index 7a579f8fe6..2f486ad652 100644 --- a/doc/bugs/test_suite_shouldn__39__t_fail_silently.mdwn +++ b/doc/bugs/test_suite_shouldn__39__t_fail_silently.mdwn @@ -1 +1,3 @@ When the test suite cannot be compiled, the build just fails silenty. This means that in automated builds there is no easy way to ensure that the generated binaries have passed the test suite, because it may not even have been run! IMHO, "make test" should fail (i.e. return a non-zero exit code) when it can't succeeed. + +> Ok, fixed. --[[Joey]] [[done]]