mirrors/git-annex
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

dropunused edge case when annex.thin caused unused object to be modified

Browse source 
dropunused: When an unused object file has gotten modified, eg due to
annex.thin being set, don't silently skip it, but display a warning and let
--force drop it.

This commit was sponsored by Ethan Aubin.
This commit is contained in:
Joey Hess 2018-12-04 12:20:34 -04:00
parent 96d2000570
commit aa8243df4c
No known key found for this signature in database
GPG key ID: DB12DB0FF05F8F38
5 changed files with 63 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

14
doc/bugs/dropunused_does_nothing/comment_3_8f80959997f6963728a8aee3765dc349._comment Normal file
View file

@ -0,0 +1,14 @@
[[!comment format=mdwn
username="joey"
subject="""comment 3"""
date="2018-12-04T15:46:05Z"
content="""
Indeed, the object seems to be there, but it looks like `dropunused`
probably for some reason fails its `inAnnex` check and so skips it.
Does `git config annex.thin` output true? If so, and if the object file you
found does not checksum to the right value, `dropunused` would skip it.
That seems to me to be a bug, it probably should delete even modified files
in this case. But I don't know if it's the bug you're seeing.
"""]]

26
doc/bugs/dropunused_does_nothing/comment_4_7e04e71d0eb03185148ab544bc24724c._comment Normal file
View file

@ -0,0 +1,26 @@
[[!comment format=mdwn
username="joey"
subject="""comment 4"""
date="2018-12-04T15:52:52Z"
content="""
Test case for the annex.thin with modified file bug:
git annex init
git annex upgrade
git config annex.thin true
touch foo
git add foo
git commit -m add
echo foo >> foo
rm foo
git commit -m rm -a
git annex unused
git annex dropunused 1
git annex unused
Now, dropunused is supposed to honor numcopies, and if an object file
has been modified, that's probably the only existing copy of that object,
and so dropunused should refuse to drop it by default. There ought to be a
warning, and the user should be able to use --force to override and drop it
anyway. I've implemented that now.
"""]]