mirrors/git-annex
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

fix build failure by avoiding refutable pattern match

Browse source
This commit is contained in:
Joey Hess 2020-12-09 12:43:38 -04:00
parent 4bce767ca6
commit a8cdcf528e
No known key found for this signature in database
GPG key ID: DB12DB0FF05F8F38
3 changed files with 23 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

2
doc/bugs/Build_failing_because_MonadFail_is_not_in_scope.mdwn
View file

@ -27,3 +27,5 @@ index 973f75629..0de145461 100644
[[!meta author=jwodder]]
[[!tag projects/datalad]]
> [[fixed|done]] --[[Joey]]

12
doc/bugs/Build_failing_because_MonadFail_is_not_in_scope/comment_1_3ebe2e53fd8e8ce673267ac2715d964c._comment Normal file
View file

@ -0,0 +1,12 @@
[[!comment format=mdwn
username="joey"
subject="""comment 1"""
date="2020-12-09T16:40:24Z"
content="""
Indeed, and thank you for the patch.
However, MonadFail often suggests a code smell, here it's the `Just ... <-`
pattern match which could potentially fail. In fact, it's not possible for
it to, so I have instead made that clear in a way that the type checker
can understand.
"""]]