mirrors/git-annex
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

forgot to add this comment

Browse source
This commit is contained in:
Joey Hess 2015-03-31 15:47:59 -04:00
parent 9e8b53644b
commit a73b8907a4
1 changed files with 18 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
doc/bugs/Uses_suggested_by_CHECKURL-CONTENTS_filename_instead_of_explicitly_specified_one_in_addurl_--file_/comment_1_73721f7709b1d8ca90522b2147428c6d._comment Normal file
View file

@ -0,0 +1,18 @@
[[!comment format=mdwn
username="joey"
subject="""comment 1"""
date="2015-03-31T18:48:12Z"
content="""
I think I didn't fully consider the `addurl --file` behavior when adding this
feature.
It seems to make sense for CLAIMURL to be used, since a special remote may
claim the url. It seems to make sense for CHECKURL to then be called (if
not --relaxed) to check that the url's content is present before adding it.
If CHECKURL-CONTENTS returns a file, it makes sense to check the file
size, but not use the suggested filename.
If CHECKURL-MULTI returns multiple files, I think it makes sense to give up
with an error.
"""]]