mirrors/git-annex
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

fix fsck reversion

Browse source 
75aab72d23 made fsck skip files whose
content is not present, but it should complain if there are not enough
copies.
This commit is contained in:
Joey Hess 2020-07-15 11:21:43 -04:00
parent b88ecb36dd
commit a7156b875c
No known key found for this signature in database
GPG key ID: DB12DB0FF05F8F38
2 changed files with 13 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Command/Fsck.hs
View file

@ -94,7 +94,7 @@ seek o = startConcurrency commandStages $ do
i <- prepIncremental u (incrementalOpt o) i <- prepIncremental u (incrementalOpt o)
let seeker = AnnexedFileSeeker let seeker = AnnexedFileSeeker
{ seekAction = commandAction' (start from i) { seekAction = commandAction' (start from i)
, checkContentPresent = Just True , checkContentPresent = Nothing
, usesLocationLog = True , usesLocationLog = True
} }
withKeyOptions (keyOptions o) False withKeyOptions (keyOptions o) False

12
doc/bugs/failing_tests_in_master.mdwn
View file

@ -12,3 +12,15 @@ checkContentPresent is set.
Everything in that and related commits Everything in that and related commits
needs to be re-examined to make sure no other inAnnex checks were lost. needs to be re-examined to make sure no other inAnnex checks were lost.
> Well, I didn't find any others.
The fsck failure is that it fails to fail when there are 0 copies of the
file. Same basic cause, but the other direction, it was skipping files
whose content is not present. Also introduced in [[!commit
75aab72d23ebf8ef0d56d7dd74c121e33d64f1f6]].
So, also need to audit everything with checkContentPresent = Just True
etc to make sure it's right. Ok, done, there were not many using it yet.
[[done]] --[[Joey]]