mirrors/git-annex
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

remove use of remoteGitConfig

Browse source 
Unfortunately one more use remains..

This should be just as fast as the other method. The remote's Git.Repo
has already had its config read, so Annex.new's call to Git.Config.read
is a noop.

Thid commit was sponsored by andrea rota.
This commit is contained in:
Joey Hess 2018-06-05 13:03:42 -04:00
parent b94294a43d
commit a5f598a6aa
No known key found for this signature in database
GPG key ID: DB12DB0FF05F8F38
2 changed files with 20 additions and 20 deletions
Download patch file Download diff file Expand all files Collapse all files

10
doc/todo/need_to_remove_remoteGitConfig_for_checkuuid_support.mdwn
View file

@ -1,12 +1,10 @@
annex-checkuuid=false prevents the git config of a remote from being read.
So, the remoteGitConfig will be an empty config when that's set.
Only a few things use remoteGitConfig. Annex.Ssh uses it, but is not
impacted by the problem.
And `git annex sync` looks at it to determine
if the remote is a FAT-formatted drive, and does updateInstead emulation.
So, that's broken for remotes with annex-checkuuid=false
I've mostly removed uses of remoteGitConfig, but there are two in
Remote.Git, which are needed for annexDifferences.
So, `annex.tune.*` config the remote won't be honored when
annex-checkuuid=false.
The best thing would be to remove remoteGitConfig, to avoid such problems
in the future. --[[Joey]]