mirrors/git-annex
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

Fixed a memory leak due to excessive strictness when committing journal files.

Browse source 
When hashing the files, the entire list of shas was read strictly.
That was entirely unnecessary, since there's a cleanup action run
after they're consumed.
This commit is contained in:
Joey Hess 2012-02-14 11:20:30 -04:00
parent 82ae30d820
commit a40ec5e03e
4 changed files with 9 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

5
doc/bugs/git_annex_add_memory_leak.mdwn
View file

@ -27,6 +27,11 @@ A history of the leaks:
Apparently fixed in versions afer 3.20120123, but this one is not
well understood.
* Committing journal files turned out to have another memory leak.
After adding a lot of files ran out of memory, this left the journal
behind and could affect other git-anne commands. Fixed in versions afer
3.20120123.
* (Note that `git ls-files --others`, which is used to find files to add,
also uses surpsisingly large amounts
of memory when you have a lot of files. It buffers