mirrors/git-annex
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

fix hang at end of PUT to proxied p2p http remote

Browse source 
sendExactly will now be sure to evaluate the whole lazy ByteString.

In this case, the lazy ByteString was exactly the right lenth.
But, it seems that L.take caused it to not actually be fully evaluated.

In servePut, this manifested as gather never being fully evaluated,
which caused the hang.

Very, very subtle, and horrible bug. Clearly the use of lazy ByteString
(or really just laziness) is at fault, and it would be very worth moving
to conduit or whatever to avoid this.
This commit is contained in:
Joey Hess 2024-07-26 19:50:15 -04:00
parent b431201e1f
commit a3dab58be2
No known key found for this signature in database
GPG key ID: DB12DB0FF05F8F38
3 changed files with 19 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

2
doc/design/p2p_protocol.mdwn
View file

@ -115,7 +115,7 @@ the client sends:
The server responds with either SUCCESS or FAILURE.
The former indicates the content is locked. It will remain
locked until the client sends:
locked until the client sends its next message, which must be:
UNLOCKCONTENT Key