fix hang at end of PUT to proxied p2p http remote
sendExactly will now be sure to evaluate the whole lazy ByteString. In this case, the lazy ByteString was exactly the right lenth. But, it seems that L.take caused it to not actually be fully evaluated. In servePut, this manifested as gather never being fully evaluated, which caused the hang. Very, very subtle, and horrible bug. Clearly the use of lazy ByteString (or really just laziness) is at fault, and it would be very worth moving to conduit or whatever to avoid this.
This commit is contained in:
parent
b431201e1f
commit
a3dab58be2
3 changed files with 19 additions and 6 deletions
|
@ -115,7 +115,7 @@ the client sends:
|
|||
|
||||
The server responds with either SUCCESS or FAILURE.
|
||||
The former indicates the content is locked. It will remain
|
||||
locked until the client sends:
|
||||
locked until the client sends its next message, which must be:
|
||||
|
||||
UNLOCKCONTENT Key
|
||||
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue