move: Fix a regression in the last release that made move --to not honor numcopies settings
This commit was sponsored by Svenne Krap on Patreon.
This commit is contained in:
parent
98d1cbd1ee
commit
a30030c4a6
4 changed files with 20 additions and 1 deletions
|
@ -1,5 +1,7 @@
|
||||||
git-annex (8.20201104) UNRELEASED; urgency=medium
|
git-annex (8.20201104) UNRELEASED; urgency=medium
|
||||||
|
|
||||||
|
* move: Fix a regression in the last release that made move --to not
|
||||||
|
honor numcopies settings.
|
||||||
* sync --content: Fix a bug where a file that was not preferred content
|
* sync --content: Fix a bug where a file that was not preferred content
|
||||||
could be transferred to a remote. This happened when the file got deleted
|
could be transferred to a remote. This happened when the file got deleted
|
||||||
after the sync started running.
|
after the sync started running.
|
||||||
|
|
|
@ -151,7 +151,7 @@ toPerform dest removewhen key afile fastcheck isthere = do
|
||||||
when fastcheck $
|
when fastcheck $
|
||||||
warning "This could have failed because --fast is enabled."
|
warning "This could have failed because --fast is enabled."
|
||||||
stop
|
stop
|
||||||
Right True -> logMove srcuuid destuuid False key $ \deststartedwithcopy ->
|
Right True -> logMove srcuuid destuuid True key $ \deststartedwithcopy ->
|
||||||
finish deststartedwithcopy $
|
finish deststartedwithcopy $
|
||||||
unlessM (expectedPresent dest key) $
|
unlessM (expectedPresent dest key) $
|
||||||
Remote.logStatus dest key InfoPresent
|
Remote.logStatus dest key InfoPresent
|
||||||
|
|
|
@ -54,3 +54,5 @@ Relevant links:
|
||||||
I'm really excited about using git-annex, and have spent 3-4 days reading documentation, past bug reports, setting up repos, transferring data, and manually testing failure cases (e.g. this one :p).
|
I'm really excited about using git-annex, and have spent 3-4 days reading documentation, past bug reports, setting up repos, transferring data, and manually testing failure cases (e.g. this one :p).
|
||||||
|
|
||||||
Thanks for all your hard work!
|
Thanks for all your hard work!
|
||||||
|
|
||||||
|
> [[fixed|done]] --[[Joey]]
|
||||||
|
|
|
@ -0,0 +1,15 @@
|
||||||
|
[[!comment format=mdwn
|
||||||
|
username="joey"
|
||||||
|
subject="""comment 2"""
|
||||||
|
date="2020-11-13T18:01:29Z"
|
||||||
|
content="""
|
||||||
|
Oh what a dumb mistake, literally a copied "False" that should be "True".
|
||||||
|
|
||||||
|
I'm going to move the next release up due to this regression, but
|
||||||
|
thankfully it doesn't result in data loss, so am not going to do a crash
|
||||||
|
priority release. Probably Monday.
|
||||||
|
|
||||||
|
The test suite also has a test case for move and numcopies now. It used to be
|
||||||
|
ok for it to only test drop and numcopies, but that changed a while back
|
||||||
|
and it should have had one already.
|
||||||
|
"""]]
|
Loading…
Add table
Add a link
Reference in a new issue