disable journalIgnorable in enableInteractiveBranchAccess
Fix a reversion that prevented --batch commands (and the assistant)
from noticing data written to the journal by other commands.
I have not identified which commit broke this for sure,
but probably it was aeca7c2207
--batch commands that wrote to the journal avoided the problem since
journalIgnorable sets unset on write. It's a little bit surprising that
nobody noticed that query --batch commands did not see data written by
other commands.
Sponsored-by: Dartmouth College's DANDI project
This commit is contained in:
parent
91abd872d3
commit
a2b1f369d1
3 changed files with 21 additions and 5 deletions
|
@ -0,0 +1,12 @@
|
|||
--batch commands are supposed to notice changes that get made to the
|
||||
journal while they are running. This way, if two batch commands are run,
|
||||
one making changes and the other reading the values, the reader notices the
|
||||
changes.
|
||||
|
||||
That does not currently happen. Looks like runUpdateOnce runs before
|
||||
enableInteractiveBranchAccess, and so sets journalIgnorable. Only if the
|
||||
batch command writes to the journal does journalIgnorable get unset, and
|
||||
then the command will notice journalled changes by itself or others.
|
||||
But query commands
|
||||
|
||||
> [[fixed|done]] --[[Joey]]
|
Loading…
Add table
Add a link
Reference in a new issue