mirrors/git-annex
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

disable journalIgnorable in enableInteractiveBranchAccess

Browse source 
Fix a reversion that prevented --batch commands (and the assistant)
from noticing data written to the journal by other commands.

I have not identified which commit broke this for sure,
but probably it was aeca7c2207

--batch commands that wrote to the journal avoided the problem since
journalIgnorable sets unset on write. It's a little bit surprising that
nobody noticed that query --batch commands did not see data written by
other commands.

Sponsored-by: Dartmouth College's DANDI project
This commit is contained in:
Joey Hess 2022-07-15 13:43:46 -04:00
parent 91abd872d3
commit a2b1f369d1
No known key found for this signature in database
GPG key ID: DB12DB0FF05F8F38
3 changed files with 21 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

12
doc/bugs/batch_commands_miss_journalled_changes_made_while_running.mdwn Normal file
View file

@ -0,0 +1,12 @@
--batch commands are supposed to notice changes that get made to the
journal while they are running. This way, if two batch commands are run,
one making changes and the other reading the values, the reader notices the
changes.
That does not currently happen. Looks like runUpdateOnce runs before
enableInteractiveBranchAccess, and so sets journalIgnorable. Only if the
batch command writes to the journal does journalIgnorable get unset, and
then the command will notice journalled changes by itself or others.
But query commands
> [[fixed|done]] --[[Joey]]