mirrors/git-annex
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

fix repo description setting bugs

Browse source 
* init: When the repository already has a description, don't change it.
* describe: When run with no description parameter it used to set
  the description to "", now it will error out.
This commit is contained in:
Joey Hess 2019-05-23 12:51:01 -04:00
parent b646a85c4a
commit a14f6ce758
No known key found for this signature in database
GPG key ID: DB12DB0FF05F8F38
5 changed files with 29 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

2
doc/bugs/git-annex-init_with_no_args_overwrites_existing_repo_description.mdwn
View file

@ -18,3 +18,5 @@ upgrade supported from repository versions: 0 1 2 3 4 5 6
local repository version: 5
(master_env_v135_py36) 13:47 [r2] $ uname -a
Linux ip-172-31-90-58.ec2.internal 4.14.114-105.126.amzn2.x86_64 #1 SMP Tue May 7 02:26:40 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
> [[fixed|done]] --[[Joey]]

16
doc/bugs/git-annex-init_with_no_args_overwrites_existing_repo_description/comment_1_7facb84de8c8148e8f12ba2c4bd5c74b._comment Normal file
View file

@ -0,0 +1,16 @@
[[!comment format=mdwn
username="joey"
subject="""comment 1"""
date="2019-05-23T16:40:50Z"
content="""
Yikes, I was surprised to see this behavior. fixed for `init`.
For `describe`, I see that when it's run with no parameter for the
description, it sets the description to "". I suppose that's what you
meant.
I suppose something could conceivably depend on the current `git annex
describe remote` behavior, but I checked and it's nowhere documented that
describe with no description is allowed -- even the --help doesn't say that
luckily. So I have also disallowed that.
"""]]