assist: operate on all files in working tree by default

Consistency with sync and internal consistency is more important than
consistency with the assistant, which is not itself consistent about
what it does when run in a subdirectory.

Note that with -C, it will still commit staged changes to files outside
the directory. Like sync does. Presumably if the user is manually
staging things, then running this command, they intend to build up a
commit.

Sponsored-by: unqueued on Patreon
This commit is contained in:
Joey Hess 2023-05-19 14:47:05 -04:00
parent c4ad9b1446
commit 9ed59dab5b
No known key found for this signature in database
GPG key ID: DB12DB0FF05F8F38
3 changed files with 33 additions and 8 deletions

View file

@ -0,0 +1,15 @@
[[!comment format=mdwn
username="joey"
subject="""comment 12"""
date="2023-05-19T18:37:28Z"
content="""
I'm also not too happy with the inconsistency of assist committing all staged
changes and syncing all file contents, but only adding files in the cwd.
I suppose that consistency with the assistant doesn't really matter. The
assistant's behavior when ran in a subdirectory is surprising,
inconsistent, and undocumented.
So I'm going to change assist to add all files. Except when -C is used,
then only add files in the specified directory.
"""]]