Some optimisations to string splitting code.
Turns out that Data.List.Utils.split is slow and makes a lot of allocations. Here's a much simpler single character splitter that behaves the same (even in wacky corner cases) while running in half the time and 75% the allocations. As well as being an optimisation, this helps move toward eliminating use of missingh. (Data.List.Split.splitOn is nearly as slow as Data.List.Utils.split and allocates even more.) I have not benchmarked the effect on git-annex, but would not be surprised to see some parsing of eg, large streams from git commands run twice as fast, and possibly in less memory. This commit was sponsored by Boyd Stephen Smith Jr. on Patreon.
This commit is contained in:
parent
dbaea98836
commit
9eb10caa27
30 changed files with 47 additions and 38 deletions
|
@ -24,7 +24,7 @@ rsyncShell command = [Param "-e", Param $ unwords $ map escape (toCommand comman
|
|||
{- rsync requires some weird, non-shell like quoting in
|
||||
- here. A doubled single quote inside the single quoted
|
||||
- string is a single quote. -}
|
||||
escape s = "'" ++ intercalate "''" (split "'" s) ++ "'"
|
||||
escape s = "'" ++ intercalate "''" (splitc '\'' s) ++ "'"
|
||||
|
||||
{- Runs rsync in server mode to send a file. -}
|
||||
rsyncServerSend :: [CommandParam] -> FilePath -> IO Bool
|
||||
|
@ -123,7 +123,7 @@ parseRsyncProgress = go [] . reverse . progresschunks
|
|||
{- Find chunks that each start with delim.
|
||||
- The first chunk doesn't start with it
|
||||
- (it's empty when delim is at the start of the string). -}
|
||||
progresschunks = drop 1 . split [delim]
|
||||
progresschunks = drop 1 . splitc delim
|
||||
findbytesstart s = dropWhile isSpace s
|
||||
|
||||
parsebytes :: String -> Maybe Integer
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue