From 9d745434f94298ab8b7cebadd6123f6c507fd9f6 Mon Sep 17 00:00:00 2001 From: silvio Date: Wed, 29 Apr 2015 19:24:55 +0000 Subject: [PATCH] Added a comment --- ..._237fdaddaa80c1e4d262d724d9aed82b._comment | 21 +++++++++++++++++++ 1 file changed, 21 insertions(+) create mode 100644 doc/bugs/dolphin_integration_file_is_broken/comment_2_237fdaddaa80c1e4d262d724d9aed82b._comment diff --git a/doc/bugs/dolphin_integration_file_is_broken/comment_2_237fdaddaa80c1e4d262d724d9aed82b._comment b/doc/bugs/dolphin_integration_file_is_broken/comment_2_237fdaddaa80c1e4d262d724d9aed82b._comment new file mode 100644 index 0000000000..3dcaa7c21c --- /dev/null +++ b/doc/bugs/dolphin_integration_file_is_broken/comment_2_237fdaddaa80c1e4d262d724d9aed82b._comment @@ -0,0 +1,21 @@ +[[!comment format=mdwn + username="silvio" + subject="comment 2" + date="2015-04-29T19:24:55Z" + content=""" +I currently use dolphin Version 14.12.3 but it's been broken for me forever. I always had my own fix but now it keeps getting overwritten by git-annex. + +the current line in my git-annex version is: + +sh -c 'cd \"$(dirname '%U')\" && git-annex get --notify-start --notify-finish -- %U' + +The problem is that %U gives an url style file (file:///some/path) which git-annex doesn't understand. + +Further more the quoting is broken because and i quote: + +\"Field codes (%F,%U) must not be used inside a quoted argument, the result of field code expansion inside a quoted argument is undefined.\" + +Additionally I don't think it's possible to prevent an arbitrary command injection unless you have the Field code as a single argument. + +The command_string_is_ignored is just the string that will be assigned to $0 which is not used. You could use it instead of $1 but didn't like using the command string as an argument. +"""]]