mirrors/git-annex
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

Avoid unsetting HOME when running certian git commands. Closes: #690193

Browse source 
Setting GIT_INDEX_FILE clobbers the rest of the environment, making git
not read ~/.gitconfig, and blow up if GECOS didn't have a name for the
user.

I'm not entirely happy with getEnvironment being run every time now,
that's somewhat expensive. It may make sense to just set GIT_COMMITTER_*
and GIT_AUTHOR_*, but I worry that clobbering the rest could break PATH,
or GIT_PATH, or something else that might be used by a command run in here.
And caching the environment is not a good idea either; it can change..
This commit is contained in:
Joey Hess 2012-10-11 12:58:03 -04:00
parent bbf2c31aa7
commit 97ea08e2d1
3 changed files with 7 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

1
debian/changelog vendored
View file

@ -4,6 +4,7 @@ git-annex (3.20121010) UNRELEASED; urgency=low
* Standard groups changed to client, transfer, archive, and backup.
Each of these has its own standard preferred content setting.
* dead: Remove dead repository from all groups.
* Avoid unsetting HOME when running certian git commands. Closes: #690193
-- Joey Hess <joeyh@debian.org> Wed, 10 Oct 2012 12:59:25 -0400