mirrors/git-annex
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

init: Fix a reversion that broke initialization on systems that need to use pid locking

Browse source 
This brings back .git/annex/misctmp, but only for init. If an init
is interrupted while probing using that temp directory, the files it left
will get deleted 1 week later by a subsequent git-annex run.
This commit is contained in:
Joey Hess 2019-09-10 13:37:07 -04:00
parent 07de0e7e9d
commit 94c75d2bd9
No known key found for this signature in database
GPG key ID: DB12DB0FF05F8F38
7 changed files with 42 additions and 13 deletions
Download patch file Download diff file Expand all files Collapse all files

4
doc/bugs/fails_to_init_under_a_directory_with_a___34__tricky__34___name/comment_2_6d57bda8ddc603f24e16018969ac780a._comment
View file

@ -42,7 +42,5 @@ running createProcess with this:
CreateProcess {cmdspec = RawCommand "git" ["update-index","--index-info"], cwd = Nothing, env = Just [("GIT_INDEX_FILE","/tmp/\56514\56481/.git/annex/index")], std_in = Inherit, std_out = Inherit, std_err = Inherit, close_fds = False, create_group = False, delegate_ctlc = False, detach_console = False, create_new_console = False, new_session = False, child_group = Nothing, child_user = Nothing, use_process_jobs = False}
This bug needs to be forwarded to http://hackage.haskell.org/process,
after checking what environment value it actually passes to the child
process in this case.
This bug needs to be forwarded to process.
"""]]

2
doc/bugs/regression__58___fails_to_detect_need_for_pidlock_on_an_NSF_mount.mdwn
View file

@ -62,3 +62,5 @@ type nfs (rw,relatime,vers=3,rsize=131072,wsize=131072,namlen=255,hard,proto=tcp
```
[[!meta author=yoh]]
> [[fixed|done]] --[[Joey]]

12
doc/bugs/regression__58___fails_to_detect_need_for_pidlock_on_an_NSF_mount/comment_4_bf6487c1740f163745b7dcc41468ec4d._comment Normal file
View file

@ -0,0 +1,12 @@
[[!comment format=mdwn
username="joey"
subject="""comment 4"""
date="2019-09-10T16:28:12Z"
content="""
Thanks for the bisection. It's not the init code that's
trying and failing to set a lock, but the misctmp cleanup code. Which is
ironically now used in setting up the temp directory that init uses to
probe for locking problems. Chicken and egg problem.
Committed a fix.
"""]]